feat: Added event for subsidy redemption reversal on the bus #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
irfanuddinahmad
force-pushed
the
iahmad/ENT-8487
branch
3 times, most recently
from
80747f4
to
d87b437
Compare
irfanuddinahmad
force-pushed
the
iahmad/ENT-8487
branch
from
d87b437
to
c38bcff
Compare
saleem-latif
approved these changes
Apr 8, 2024
jajjibhai008
approved these changes
Apr 8, 2024
iloveagent57
reviewed
Apr 8, 2024
| @@ -28,6 +30,14 @@ def listen_for_transaction_reversal(sender, **kwargs): | |||
| raise ValueError(msg) | |||
| try: | |||
| EnterpriseApiClient().cancel_fulfillment(transaction.fulfillment_identifier) | |||
| subsidy_redemption = SubsidyRedemption( | |||
| subsidy_identifier=transaction.subsidy_access_policy_uuid, | |||
There was a problem hiding this comment.
Hmm, doesn't have to be addressed in this PR, but subsidy_identifier is a really confusing name for this key - as a casual reader of the code, I'd expect a key with that name to point to an instance of subsidy.models.Subsidy :)
There was a problem hiding this comment.
@iloveagent57 the challenge was to come up with a reasonably generic identifier without injecting too much of our policy/budget/subsidy lingo into the event.
11 tasks
|
Closed in favor of: #244 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an event on the event bus whenever a redemption reversal signal is received from the ledger.
JIRA: ENT-8487
Related PR openedx/enterprise-access#434
Merge checklist