feat: Reset request cache before handling event #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a just-in-case measure -- we don't know of any specific code that handles events and relies on the cache. But it's likely to come up at some point. Ticket: openedx/openedx-events#235
2 tasks
robrap
approved these changes
Sep 20, 2023
| # Before processing, make sure our db connection is still active | ||
| _reconnect_to_db_if_needed() | ||
| # Before processing, make sure our application state is similar to | ||
| # that of a new Django request. (Mimic setup/teardown.) |
There was a problem hiding this comment.
Non-blocking question: By "setup/teardown", are you referring to something related to Django requests, or just unit tests or some such? If Django requests, I have openedx/openedx-events#236 open, because I'm wondering if there isn't a more general solution to this problem.
There was a problem hiding this comment.
Django requests. I wonder if it would make sense to link to that issue to give context that "mimic setup/teardown" is more aspirational than concrete. :-)
There was a problem hiding this comment.
- It wouldn't hurt to link to that issue and add some clarity.
- It actually feels like
prepare_for_new_work_cycleprobably belongs in openedx-events, which would give this benefit to Redis for free. Maybe we could create an issue for that, and let the Redis team know about it. In place of copying this change, maybe they can implement a more shareable solution?
There was a problem hiding this comment.
Created openedx/openedx-events#270
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a just-in-case measure -- we don't know of any specific code that handles events and relies on the cache. But it's likely to come up at some point.
Ticket: openedx/openedx-events#235
Merge checklist:
Check off if complete or not applicable: