Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library Search Home Tab - Recent and Components #1039

Closed
bradenmacdonald opened this issue May 24, 2024 · 6 comments
Closed

Library Search Home Tab - Recent and Components #1039

bradenmacdonald opened this issue May 24, 2024 · 6 comments

Comments

@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented May 24, 2024

Building on #1036 , #1037 , and #1038 : create the "Home" tab of the Library search view.

Designs: Mid-Fi Figma link

In Scope:

  1. The "Recently Modified" row shows 2-4 matching results (for now they're all components but in the future they'll include collections and units), sorted by modified date (recently modified first). This section always displays the most recently modified content and functions independently of any "sort by" or "filter" options a user may choose.
    Mockup of Recently Modified
    • There is no "View All" link for the recently modified section.
  2. The "Components" row shows 2-4 matching components, sorted by the current "Sort By" setting. Clicking "View all" jumps to the "Components" tab.
    Screenshot
  3. The title of the "Components" row specifies how many matching components there are in total.
  4. If there are no components, don't display anything except the empty state message (see Figma).
  5. Include the filters from Library Home - Filter by Tags #1048 and Library Home - Filter by Content Type #1049

🛑 Out of Scope:
6. The "Collections" row is out of scope for now.

@bradenmacdonald bradenmacdonald added this to the Lib Relaunch 1: Library Home Page milestone May 24, 2024
@jmakowski1123
Copy link

Suggested modification to the "view all" button on the "recently modified" section. Tldr I think we should just remove the "view all" button from the "recently modified" section and accept that that section only contains a limited number of contents. https://www.figma.com/design/Y3gSyrpG6uncUUfjK7eQuo?node-id=1921-103844#815172223

@bradenmacdonald bradenmacdonald removed this from the Lib Relaunch 1: Library Home Page milestone Jun 13, 2024
@yusuf-musleh
Copy link
Contributor

@bradenmacdonald @jmakowski1123 Regarding the "Recently Modified" section:

The "Recently Modified" row shows 2-4 matching results ...

Does this imply search results? i.e. does searching impact what is shown is shown in the "Recently Modified" section? Or should it always just show the the most recently modified components (units/collections in future), regardless of search/filter/sorting applied on the page?

@bradenmacdonald
Copy link
Contributor Author

@yusuf-musleh If I remember correctly, we decided that section just always shows the most recently modified things regardless of search/filters.

@pomegranited
Copy link
Contributor

@ChrisChV
Copy link
Contributor

@jmakowski1123 @lizc577 @sdaitzman @marcotuts Reminder about this is ready for AC testing, or if it's ready to move to Done

@bradenmacdonald
Copy link
Contributor Author

Note: are going to refactor this and simplify it significantly in a new story: #1230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

5 participants