Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collections Page - Filter by Content Type #1168

Closed
jmakowski1123 opened this issue Jul 17, 2024 · 4 comments
Closed

Collections Page - Filter by Content Type #1168

jmakowski1123 opened this issue Jul 17, 2024 · 4 comments

Comments

@jmakowski1123
Copy link

jmakowski1123 commented Jul 17, 2024

If a Collection has content populated in it, users can filter that content using Content Type.

Screen Shot 2024-07-17 at 3 56 42 PM

See implementation details for filtering by Content Type at the Library level: #1049. A similar implementation needs to happen at the Collection level, but the filtering is limited to content contained within the Collection.

@kdmccormick kdmccormick transferred this issue from openedx-unsupported/frontend-app-library-authoring Jul 18, 2024
@sdaitzman
Copy link

I noticed that when filtering to only a problem subtype, when there's a blank problem, the count / problem type match is inconsistent.

Image

In the screenshot above, I selected the "Checkboxes" type, which has one match. The parent "Problem" type (tagged with two matches) is selected as well, and both the problem components are selected.

I would expect this to only show the 1 matching problem.

@bradenmacdonald
Copy link
Contributor

^ This is a weird edge case when your library only has a single type of problem, alongside blank problems. The issue is that whenever you check all the available sub-types of problem, it will include blank problems as well, since it interprets that the same as "all problems". We could address this in the future by explicitly adding "Blank Problem" as a sub-type of problem. But there are other random sub-types as well that won't show up.

@navinkarkera
Copy link
Contributor

@jmakowski1123 @lizc577 @sdaitzman @marcotuts This is ready for AC testing on the sandbox

@jmakowski1123
Copy link
Author

Looks good!

@jmakowski1123 jmakowski1123 closed this as completed by moving to Done in Libraries Overhaul Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants