Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] confusing limit on library component count #1456

Open
bradenmacdonald opened this issue Oct 31, 2024 · 9 comments
Open

[Bug] confusing limit on library component count #1456

bradenmacdonald opened this issue Oct 31, 2024 · 9 comments
Assignees
Labels
bug Report of or fix for something that isn't working as intended

Comments

@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented Oct 31, 2024

  1. Improve error message when creating more than 1,000 components in a course. Currently it gives a generic error. It should say specifically that creating a component failed because the library has reached the maximum number of components supported.
  2. Raise the limit in the platform from 1,000 to 100,000.
@bradenmacdonald bradenmacdonald added the bug Report of or fix for something that isn't working as intended label Oct 31, 2024
@bradenmacdonald
Copy link
Contributor Author

@jmakowski1123 @ormsbee Please review this ticket.

@ormsbee
Copy link
Contributor

ormsbee commented Oct 31, 2024

@bradenmacdonald: How far do you think we could safely crank the limit on the search side of things? I'm tempted to just turn it up to 100K and see what happens. 😛

@bradenmacdonald
Copy link
Contributor Author

@ormsbee I can't say from experience but I would hope it works fine even at 100K.

@pomegranited
Copy link
Contributor

@jmakowski1123 @lizc577 @sdaitzman @marcotuts This is ready for AC testing on the sandbox

@ChrisChV
Copy link
Contributor

@jmakowski1123 @lizc577 @sdaitzman @marcotuts Friendly reminder that this is ready for AC testing on the sandbox

@jmakowski1123
Copy link

jmakowski1123 commented Dec 23, 2024

Not sure how to test this? Is there a file with 100k components I could try to import?

@pomegranited
Copy link
Contributor

Oh my apologies @jmakowski1123 , this is a hard one to test.

@bradenmacdonald is it worth taking a small amount of budget from the new project to create a huge library to test this issue, (and see how Meilisearch performs with the new limit)?

@bradenmacdonald
Copy link
Contributor Author

@pomegranited I believe various people have already done that in the process of working on these issues - it should be relatively simple to paste a script into the console that mass-creates library blocks, and run that on the sandbox. In any case I agree it's a good idea to have a large library for testing on the sandbox.

@pomegranited
Copy link
Contributor

I've got a script running to populate lib:OpenCraft:NL with 100,000 components -- will let you know when it's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended
Projects
Status: Ready for AC testing
Development

No branches or pull requests

5 participants