Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open Editors in a Modal (library components only) [FC-0062] #1357

Merged
merged 12 commits into from
Oct 8, 2024
Merged

Open Editors in a Modal (library components only) [FC-0062] #1357

merged 12 commits into from
Oct 8, 2024
+845 −1,220

Commits on Oct 4, 2024

  1. feat: allow opening editors in modals

    @bradenmacdonald
    bradenmacdonald committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    05469c4 View commit details
    Browse the repository at this point in the history

  2. refactor: add an EditorContext

    @bradenmacdonald
    bradenmacdonald committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    91ef29e View commit details
    Browse the repository at this point in the history

  3. test: update tests accordingly

    @bradenmacdonald
    bradenmacdonald committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    e0dafcf View commit details
    Browse the repository at this point in the history

  4. refactor: typing improvements

    @bradenmacdonald
    bradenmacdonald committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    31cd60d View commit details
    Browse the repository at this point in the history

  5. refactor: remove 'module' self-import from 'hooks'

    @bradenmacdonald
    bradenmacdonald committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    f25913c View commit details
    Browse the repository at this point in the history

  6. test: update tests

    @bradenmacdonald
    bradenmacdonald committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    fa135fd View commit details
    Browse the repository at this point in the history

  7. test: make testUtils call clearAllMocks() automatically :)

    @bradenmacdonald
    bradenmacdonald committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    f164328 View commit details
    Browse the repository at this point in the history

  8. fix: Mark <EditorPage> as not allowing children

    @bradenmacdonald
    bradenmacdonald committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    2dddaac View commit details
    Browse the repository at this point in the history

  9. fix: blank problems were not being edited in a modal

    @bradenmacdonald
    bradenmacdonald committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    3d8684a View commit details
    Browse the repository at this point in the history

  10. test: improve coverage

    @bradenmacdonald
    bradenmacdonald committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    204be29 View commit details
    Browse the repository at this point in the history

  11. test: improve coverage

    @bradenmacdonald
    bradenmacdonald committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    89a1bff View commit details
    Browse the repository at this point in the history

  12. fix: add missing props for <ModalDialog>

    @bradenmacdonald
    bradenmacdonald committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    e8f87ba View commit details
    Browse the repository at this point in the history