feat: show error msg from server on paste [FC-0062] #1378
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @navinkarkera! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
navinkarkera
force-pushed
the
navin/paste_error_msg
branch
from
b72bec2
to
96f922f
Compare
navinkarkera
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1378 +/- ##
=======================================
Coverage 93.01% 93.01%
=======================================
Files 1035 1035
Lines 19632 19638 +6
Branches 4172 4172
=======================================
+ Hits 18261 18267 +6
Misses 1306 1306
Partials 65 65 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
LGTM 👍
Thank you for your work, @navinkarkera!
- I tested this using the instructions from this pr
- I read through the code
- I checked for accessibility issues
- Includes documentation
| axiosMock.onPost(pasteUrl).reply(() => Promise.reject({ | ||
| customAttributes: { | ||
| httpErrorStatus: 400, | ||
| httpErrorResponseData: JSON.stringify({ block_type: errMsg }), | ||
| }, | ||
| })); |
There was a problem hiding this comment.
Nit: Did you try the createAxiosError function from the testUtils.tsx?
|
Is it possible to disable the Open Response block in this PR?
It would be great to keep these states in sync with the backend. Could you just check if this is an easy/fast improvement? If not, I think it is fine to leave this way for now. |
|
Yes, open response and drag and drop should be disabled as well for now. We only support text, problem and video. If we have time to get "advanced editors" working, we can turn on Drag and Drop. |
Description
Parse and display error message from server on paste from clipboard failure.
Depends on: openedx/edx-platform#35633
Supporting information
Private-ref: https://tasks.opencraft.com/browse/FAL-3860Testing instructions
LIBRARY_UNSUPPORTED_BLOCKSsetting from feat: configuration to block unsupported types while pasting in library [FC-0062] edx-platform#35633