feat: Editor bar visibility

[vladislavkeblysh]

Description

• Fixed editor bar visibility when scrolling up

[openedx-webhooks]

Thanks for the pull request, @vladislavkeblysh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[itsjeyd]

@vladislavkeblysh Thank you for this contribution!

@jmakowski1123 Another set of changes that may or may not require product review.

• Palm backport: feat: Editor bar visibility (palm.master) #581
• Quince backport: feat: Editor bar visibility (quince.master) #583

CC @mphilbrick211

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b467298) 92.41% compared to head (42a26e4) 92.41%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #582   +/-   ##
=======================================
  Coverage   92.41%   92.41%           
=======================================
  Files         169      169           
  Lines        3468     3468           
  Branches      900      900           
=======================================
  Hits         3205     3205           
  Misses        243      243           
  Partials       20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ayub02]

@awais-ansari this looks good to me.

[sundasnoreen12]

The modification of the z-index value from 3 to 9999 is impacting other sections of the MFE, as illustrated in the attached screenshots depicting the "before" and "after" states.

Before

After

[mphilbrick211]

HI @jmakowski1123 - does this have a master product ticket?

[jmakowski1123]

This is approved.

[awais-ansari]

@vladislavkeblysh did you get a chance to review this change? This is still breaking the UI.

[itsjeyd]

This is approved.

Thank you @jmakowski1123.

@vladislavkeblysh Changing status to In Eng Review now, for this PR and Palm/Quince backports (#581, #583).

CC @awais-ansari

[vladislavkeblysh]

@awais-ansari I will see it soon, thank you for reminding!

[vladislavkeblysh]

@awais-ansari Fixed

[sundasnoreen12]

PR LGTM

[awais-ansari]

@vladislavkeblysh Please update the PR.

[vladislavkeblysh]

@awais-ansari done

[openedx-webhooks]

@vladislavkeblysh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.