feat: add recommendations modal #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahtesham-quraish
force-pushed
the
ahtesham/VAN-1601/design
branch
from
c1b4d94
to
75a7524
Compare
Description: Add recommendations buttons and modal for painted door experiment VAN-1601
ahtesham-quraish
force-pushed
the
ahtesham/VAN-1601/design
branch
from
75a7524
to
6cecc38
Compare
zainab-amir
changed the base branch from
master
to
recommendations-painted-door
ahtesham-quraish
force-pushed
the
ahtesham/VAN-1601/design
branch
from
0c7079b
to
8d9177b
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## recommendations-painted-door #189 +/- ##
================================================================
+ Coverage 96.40% 96.44% +0.03%
================================================================
Files 184 187 +3
Lines 1725 1742 +17
Branches 309 309
================================================================
+ Hits 1663 1680 +17
Misses 57 57
Partials 5 5
☔ View full report in Codecov by Sentry. |
ahtesham-quraish
force-pushed
the
ahtesham/VAN-1601/design
branch
5 times, most recently
from
904f819
to
08780d0
Compare
src/containers/LearnerDashboardHeader/CollapsedHeader/index.jsx
Outdated
Show resolved
Hide resolved
src/containers/LearnerDashboardHeader/CollapsedHeader/index.jsx
Outdated
Show resolved
Hide resolved
src/containers/LearnerDashboardHeader/CollapsedHeader/index.jsx
Outdated
Show resolved
Hide resolved
ahtesham-quraish
force-pushed
the
ahtesham/VAN-1601/design
branch
2 times, most recently
from
005d10e
to
4ee6543
Compare
mubbsharanwar
approved these changes
Aug 16, 2023
src/containers/LearnerDashboardHeader/CollapsedHeader/CollapseMenuBody.test.jsx
Show resolved
Hide resolved
ahtesham-quraish
force-pushed
the
ahtesham/VAN-1601/design
branch
3 times, most recently
from
0ad5467
to
fe88e69
Compare
ahtesham-quraish
force-pushed
the
ahtesham/VAN-1601/design
branch
from
fe88e69
to
743c233
Compare
ahtesham-quraish
merged commit 3bad489
into
recommendations-painted-door
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add recommendations buttons and modal for painted door experiment
VAN-1601
It has been tested locally.
This is modal screenshot