-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: updated frontend-build & frontend-platform major versions #1391
Conversation
…bilalqamar95/jest-v29-upgrade
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1391 +/- ##
==========================================
- Coverage 88.88% 87.70% -1.18%
==========================================
Files 307 307
Lines 5288 5288
Branches 1345 1311 -34
==========================================
- Hits 4700 4638 -62
- Misses 572 633 +61
- Partials 16 17 +1 ☔ View full report in Codecov by Sentry. |
…o bilalqamar95/jest-v29-upgrade
Hello, I did a validation test with a local branch and they passed well, although I see that since it is a very large repo there are some components that do not have a test, but I only found 2 warnings. If you want me to review something specific, I will be happy to review it, greetings Juan Carlos (Aulasneo) |
…o bilalqamar95/jest-v29-upgrade
@BilalQamar95 can you rebase this to resolve conflicts? |
…o bilalqamar95/jest-v29-upgrade
@feanil I have rebased the PR and resolved conflicts |
@feanil can you please re-review this PR? Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me. FYI @openedx/committers-frontend-app-learning I'm merging this since it's some maintenance that had stagnated on review previously and was already in progress. In the future I'll leave these reviews to you.
Thanks @feanil ! FYI due to some time off and other factors I won't be able to start my maintainership in earnest until Aug 26th, but I can review things like this starting then :) |
Description
frontend-build
tov14
&frontend-platform
tov8
along with respective edx packagesjest
tov29