Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated frontend-build & frontend-platform major versions #1391

Merged
merged 9 commits into from
Aug 14, 2024

Conversation

BilalQamar95
Copy link
Contributor

Description

  • Major version upgrades, Updating frontend-build to v14 & frontend-platform to v8 along with respective edx packages
  • Updated jest to v29

@BilalQamar95 BilalQamar95 self-assigned this May 20, 2024
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.70%. Comparing base (5ae8646) to head (6e80676).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1391      +/-   ##
==========================================
- Coverage   88.88%   87.70%   -1.18%     
==========================================
  Files         307      307              
  Lines        5288     5288              
  Branches     1345     1311      -34     
==========================================
- Hits         4700     4638      -62     
- Misses        572      633      +61     
- Partials       16       17       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BilalQamar95 BilalQamar95 marked this pull request as ready for review May 31, 2024 13:52
jest.config.js Show resolved Hide resolved
@jciasenza
Copy link

Hello, I did a validation test with a local branch and they passed well, although I see that since it is a very large repo there are some components that do not have a test, but I only found 2 warnings. If you want me to review something specific, I will be happy to review it, greetings Juan Carlos (Aulasneo)

@feanil
Copy link
Contributor

feanil commented Aug 7, 2024

@BilalQamar95 can you rebase this to resolve conflicts?
Thanks @jciasenza for the review. I can do a final pass and coordinate merging once everything is green and merge ready.

@feanil feanil added the maintenance Routine upkeep necessary for the health of the platform label Aug 7, 2024
@BilalQamar95
Copy link
Contributor Author

@BilalQamar95 can you rebase this to resolve conflicts? Thanks @jciasenza for the review. I can do a final pass and coordinate merging once everything is green and merge ready.

@feanil I have rebased the PR and resolved conflicts

@BilalQamar95
Copy link
Contributor Author

@feanil can you please re-review this PR? Thank you

Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. FYI @openedx/committers-frontend-app-learning I'm merging this since it's some maintenance that had stagnated on review previously and was already in progress. In the future I'll leave these reviews to you.

@feanil feanil merged commit 71c2a31 into master Aug 14, 2024
6 of 7 checks passed
@feanil feanil deleted the bilalqamar95/jest-v29-upgrade branch August 14, 2024 15:20
@bradenmacdonald
Copy link
Contributor

Thanks @feanil ! FYI due to some time off and other factors I won't be able to start my maintainership in earnest until Aug 26th, but I can review things like this starting then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Routine upkeep necessary for the health of the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants