fix: iframe height for discussions sidebar

[ihor-romaniuk]

Description

This merge request contains a height fix to avoid clipping the content of the iframe for discussions sidebar on mobile devices.

Related PR

• quince branch: fix: iframe height for discussions sidebar #1392
• redwood branch: fix: iframe height for discussions sidebar #1404

Screenshots:

Before	After

[openedx-webhooks]

Thanks for the pull request, @ihor-romaniuk!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-aurora. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.83%. Comparing base (e577efb) to head (5a276c2).
Report is 10 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1393      +/-   ##
==========================================
+ Coverage   88.76%   88.83%   +0.07%     
==========================================
  Files         305      307       +2     
  Lines        5234     5268      +34     
  Branches     1297     1338      +41     
==========================================
+ Hits         4646     4680      +34     
  Misses        572      572              
  Partials       16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[itsjeyd]

@ihor-romaniuk Thank you for this contribution! Please let us know when it is ready for review.

[ihor-romaniuk]

@itsjeyd It's ready for review.

[itsjeyd]

Thanks @ihor-romaniuk.

@openedx/2u-aurora This PR is ready for engineering review.

[itsjeyd]

Hey @openedx/committers-frontend, would you be able to review this PR, together with corresponding backports for Quince (#1392) and Redwood (#1404)?

[brian-smith-tcril]

@ihor-romaniuk thank you so much for this! Would you mind adding screenshots for a few desktop viewport widths as well to verify the sidebar still displays as expected outside of mobile?

[open-craft-grove]

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

[brian-smith-tcril]

I just tested this on the sandbox here (https://app.pr-1393-c25332.sandboxes.opencraft.hosting/learning/course/course-v1:demo+Course+1/block-v1:demo+Course+1+type@sequential+block@4e1de5e13fc3422997fe246b40a43aa1/block-v1:demo+Course+1+type@vertical+block@78b75020d3894fdfa8b4994f97275294) and I noticed an issue when changing the width from 990px to 992px

990px

992px

[itsjeyd]

Thanks for taking the review for this PR @brian-smith-tcril!

[ihor-romaniuk]

@brian-smith-tcril Thanks for your comment. I have fixed the issue and it's ready for check.

[open-craft-grove]

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

[brian-smith-tcril]

LGTM! Thank you for this!

[itsjeyd]

Hey @brian-smith-tcril, could you hit the merge button here when you get a minute?

[openedx-webhooks]

@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.