Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass extra prop to plugin slot #1494

Merged
merged 1 commit into from
Oct 11, 2024
Merged

fix: pass extra prop to plugin slot #1494

merged 1 commit into from
Oct 11, 2024

Conversation

mubbsharanwar
Copy link
Contributor

Passing model as a prop to plugin slot for dynamic model selection

SONIC-717

Copy link
Member

@aht007 aht007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

passing model as a prop to plugin slot for dynamic model selection
SONIC-717
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.69%. Comparing base (9a83d67) to head (6248a54).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1494   +/-   ##
=======================================
  Coverage   88.69%   88.69%           
=======================================
  Files         312      312           
  Lines        5501     5501           
  Branches     1328     1365   +37     
=======================================
  Hits         4879     4879           
  Misses        605      605           
  Partials       17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mubbsharanwar mubbsharanwar merged commit 798c51b into master Oct 11, 2024
8 checks passed
@mubbsharanwar mubbsharanwar deleted the manwar/SONIC-717 branch October 11, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants