Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency redux to v4.2.1 #934

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 21, 2022

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
redux (source) 4.1.2 -> 4.2.1 age adoption passing confidence

Release Notes

reduxjs/redux (redux)

v4.2.1

Compare Source

This bugfix release removes the isMinified internal check to fix a compat issue with Expo. That check has added in early 2016, soon after Redux 3.0 was released, at a time when it was still less common to use bundlers with proper production build settings. Today that check is irrelevant, so we've removed it.

What's Changed

Full Changelog: reduxjs/redux@v4.2.0...v4.2.1

v4.2.0

Compare Source

This release marks the original createStore API as @deprecated to encourage users to migrate to Redux Toolkit, and adds a new legacy_createStore API as an alias without the deprecation warning.

Goal

Redux Toolkit (the @reduxjs/toolkit package) is the right way for Redux users to write Redux code today:

https://redux.js.org/introduction/why-rtk-is-redux-today

Unfortunately, many tutorials are still showing legacy "hand-written" Redux patterns, which result in a much worse experience for users. New learners going through a bootcamp or an outdated Udemy course just follow the examples they're being shown, don't know that RTK is the better and recommended approach, and don't even think to look at our docs.

Given that, the goal is to provide them with a visual indicator in their editor, like createStore . When users hover over the createStore import or function call, the doc tooltip recommends using configureStore from RTK instead, and points them to that docs page. We hope that new learners will see the strikethrough, read the tooltip, read the docs page, learn about RTK, and begin using it.

To be extremely clear:

WE ARE NOT GOING TO ACTUALLY REMOVE THE createStore API, AND ALL YOUR EXISTING CODE WILL STILL CONTINUE TO WORK AS-IS!

We are just marking createStore as "deprecated":

"the discouragement of use of some feature or practice, typically because it has been superseded or is no longer considered efficient or safe, without completely removing it or prohibiting its use"

For additional details, see the extensive discussion in https://github.com/reduxjs/redux/issues/4325 .

Rationale

  • RTK provides a vastly improved Redux usage experience, with APIs that simplify standard usage patterns and eliminate common bugs like accidental mutations
  • We've had suggestions to merge all of RTK into the redux core package, or fully deprecate the entire redux package and rename it to @reduxjs/core. Unfortunately, those bring up too many complexities:
    • We already had a package rename from redux-starter-kit to @reduxjs/toolkit, and all of our docs and tutorials have pointed to it for the last three years. I don't want to put users through another whiplash package transition for no real benefit
    • Merging or rearranging our packages would effectively require merging all of the Redux repos into a single monorepo. That would require hundreds of hours of effort from us maintainers, including needing to somehow merge all of our docs sites together. We don't have the time to do that.
  • I don't want to add runtime warnings that would be really annoying

So, this is the minimum possible approach we can take to reach out to users who otherwise would never know that they are following outdated patterns, while avoiding breaking running user code or having to completely rewrite our package and repo structure.

Results

When a user imports createStore in their editor, they will see a visual strikethrough. Hovering over it will show a doc tooltip that encourages them to use configureStore from RTK, and points to an explanatory docs page:

image

Again, no broken code, and no runtime warnings.

If users do not want to see that strikethrough, they have three options:

  • Follow our suggestion to switch over to Redux Toolkit and configureStore
  • Do nothing. It's just a visual strikethrough, and it doesn't affect how your code behaves. Ignore it.
  • Switch to using the legacy_createStore API that is now exported, which is the exact same function but with no @deprecation tag. The simplest option is to do an aliased import rename:

image

What's Changed

Full Changelog: reduxjs/redux@v4.1.2...v4.2.0


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.89%. Comparing base (d880aac) to head (8e5723b).
Report is 1 commits behind head on master.

Current head 8e5723b differs from pull request most recent head 1d2edac

Please upload reports for the commit 1d2edac to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #934      +/-   ##
==========================================
- Coverage   88.83%   87.89%   -0.95%     
==========================================
  Files         307      264      -43     
  Lines        5268     4484     -784     
  Branches     1338     1130     -208     
==========================================
- Hits         4680     3941     -739     
+ Misses        572      529      -43     
+ Partials       16       14       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renovate renovate bot force-pushed the renovate/redux-4.x branch 2 times, most recently from 9093e1c to 67726bc Compare June 13, 2022 13:39
@renovate renovate bot force-pushed the renovate/redux-4.x branch 2 times, most recently from 885ceb6 to 414e6d7 Compare July 26, 2022 05:46
@renovate renovate bot force-pushed the renovate/redux-4.x branch 3 times, most recently from 5a4d40a to be53597 Compare September 13, 2022 06:07
@renovate renovate bot force-pushed the renovate/redux-4.x branch 3 times, most recently from 03ab7d6 to a0d901e Compare October 19, 2022 11:44
@renovate renovate bot force-pushed the renovate/redux-4.x branch 4 times, most recently from e780929 to 261e26c Compare October 31, 2022 15:54
@renovate renovate bot force-pushed the renovate/redux-4.x branch 3 times, most recently from 550d4bd to dea2e03 Compare November 7, 2022 18:02
@renovate renovate bot force-pushed the renovate/redux-4.x branch 3 times, most recently from 420741e to e6e9695 Compare November 23, 2022 09:12
@renovate renovate bot force-pushed the renovate/redux-4.x branch 14 times, most recently from ce3418a to 110d49b Compare September 19, 2024 16:57
@renovate renovate bot force-pushed the renovate/redux-4.x branch 9 times, most recently from 3ea70a8 to 87d313f Compare September 23, 2024 19:15
@renovate renovate bot force-pushed the renovate/redux-4.x branch 3 times, most recently from 2d4e20c to c017595 Compare October 3, 2024 21:38
@renovate renovate bot force-pushed the renovate/redux-4.x branch 2 times, most recently from 3479a03 to ccf5c0b Compare October 7, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants