Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Add upgrade banner in the FC47 Primary Course card view #340

Open
Tracked by #293
moiz994 opened this issue Jun 11, 2024 · 3 comments · Fixed by edx/edx-mobile-marketplace-android#9
Open
Tracked by #293
Assignees

Comments

@moiz994
Copy link

moiz994 commented Jun 11, 2024

Based on the changes implemented in FC47, the Learn tab has changed to show a primary course card instead of a course list. We need to incorporate the upgrade banner on the primary course card.

Example UI of new upgrade banner below:
image

Copy of upgrade button should be the same as the current upgrade banner which is "Upgrade to access more features".
Icon to replace the lock icon: https://www.figma.com/design/iZ56YMjbRMShCCDxqrqRrR/Open-edX-Mobile-App-All-Screens-v2.1?node-id=14959-174213&t=UtbU6epvpSMhxkYJ-4
image

@moiz994
Copy link
Author

moiz994 commented Jun 11, 2024

@sdaitzman @ekangedx I've seen on the web somewhere that we used the trophy icon for upgrades instead of locks. It also helps us avoid confusion when using lock icons with users.

Let me know if the icon of choice works

@sdaitzman
Copy link

Hi @moiz994, thanks for tracking this, I agree this icon change makes sense! In anticipation of updating to that icon, I've added it to our icons on the Unified Components page.

There's an example of the primary course card with that icon in Figma here. I'll also add this to the next mobile design weekly agenda to confirm the decision, since I know some others on that call were interested in changing that icon.

@moiz994
Copy link
Author

moiz994 commented Jun 12, 2024

sure, sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants