Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable Programs view for new dashboard navigation #328

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

omerhabib26
Copy link
Contributor

@omerhabib26 omerhabib26 commented Jun 4, 2024

Description

  • Update/optimize ProgramFragment
  • enable ProgramFragment for both dashboards(list/gallery)
  • added InDevelopmentFragment if programs not available.

Design: https://www.figma.com/design/iZ56YMjbRMShCCDxqrqRrR/Open-edX-Mobile-App-All-Screens-v2.1?node-id=16217-63561&t=kdCxIN8hh0ZOch7C-0

Learn(only courses as List) Learn(Courses(list)+Programs)
Learn_courses_list
List_programs.webm
Learn(only courses as Gallery) Learn(Courses(gallery)+Programs)
Learn_courses_gallery
Gallery_Programs.webm

fix: LEARNER-10035

dixidroid
dixidroid previously approved these changes Jun 6, 2024
- Update/optimise ProgramFragment
- enable ProgramFragment for both dashboards(list/gallery)
- hide dropdown on Learn Tab if programs not available

fix: LEARNER-10035
Copy link
Contributor

@volodymyr-chekyrta volodymyr-chekyrta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@volodymyr-chekyrta volodymyr-chekyrta merged commit 09b422a into openedx:develop Jun 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Move ProgramFragment Parameters from Constructor to newInstance Function
3 participants