Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: UI Issues on Auth Screens #332

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

HamzaIsrar12
Copy link
Contributor

Description:

  1. Fix Modal Design and Autofill on Register Screen After SSO

    • Redesign the modal that appears after a successful SSO.

    • Autofill the "Full Name" and "Email" fields with SSO data.

  2. Add Password Visibility Toggle

    • Add an eye icon (Visibility Toggle Icon) to the Password fields on the SignIn and SignUp screens to allow toggling password visibility.

Add an eye icon (Visibility Toggle Icon) to the Password fields on
SignIn and SignUp screens to allow toggling password visibility.

Fixes: Issue#331
@HamzaIsrar12 HamzaIsrar12 linked an issue Jun 6, 2024 that may be closed by this pull request
@HamzaIsrar12 HamzaIsrar12 self-assigned this Jun 6, 2024
omerhabib26
omerhabib26 previously approved these changes Jun 11, 2024
Copy link
Contributor

@omerhabib26 omerhabib26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎸

@HamzaIsrar12
Copy link
Contributor Author

@volodymyr-chekyrta please spare some time to review this PR. 😄

@HamzaIsrar12 HamzaIsrar12 merged commit 5c887eb into openedx:develop Jun 11, 2024
3 checks passed
@HamzaIsrar12 HamzaIsrar12 deleted the hamza/fix_auth_ui branch June 11, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Fix UI Issues on Auth Screens
3 participants