-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [FC-0047] xBlock offline mode #346
Conversation
Thanks for the pull request, @PavloNetrebchuk! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
# Conflicts: # app/src/main/java/org/openedx/app/di/ScreenModule.kt
ce66a2a
to
b9f4a46
Compare
b9f4a46
to
7de4862
Compare
6f688a8
to
f1642ba
Compare
# Conflicts: # app/src/main/java/org/openedx/app/AppViewModel.kt # app/src/main/java/org/openedx/app/di/ScreenModule.kt # app/src/test/java/org/openedx/AppViewModelTest.kt
18b5fc5
to
060b065
Compare
# Conflicts: # course/src/main/java/org/openedx/course/presentation/outline/CourseOutlineViewModel.kt # course/src/main/java/org/openedx/course/presentation/videos/CourseVideoViewModel.kt
4263dc9
to
02404e0
Compare
…offline # Conflicts: # app/src/main/java/org/openedx/app/AppActivity.kt # app/src/main/java/org/openedx/app/di/AppModule.kt # app/src/main/java/org/openedx/app/room/AppDatabase.kt # core/src/main/java/org/openedx/core/data/api/CourseApi.kt # core/src/main/java/org/openedx/core/module/db/DownloadDao.kt # core/src/main/res/values/strings.xml # course/src/main/java/org/openedx/course/presentation/dates/CourseDatesScreen.kt # course/src/main/java/org/openedx/course/presentation/dates/CourseDatesViewModel.kt # course/src/main/java/org/openedx/course/presentation/dates/DashboardUIState.kt
Hi @PavloNetrebchuk, thank you for all your work on this offline xBlock effort. I just wanted to note that the course-level tab title should be Downloads, not Offline. The title varied a lot in earlier design files, but we decided to standardize on Downloads at a mobile design weekly call |
…offline # Conflicts: # course/src/main/res/values-uk/strings.xml
796cced
to
d85289f
Compare
reviewing... |
https://www.figma.com/design/iZ56YMjbRMShCCDxqrqRrR/Open-edX-Mobile-App-All-Screens-v2.1?node-id=3240-20123&t=TDhBl4mEV0pNeAEs-0
Offline xBlock logic
offline.mp4