Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fullstory Analytics SDK Implementation #347

Merged
merged 11 commits into from
Jul 9, 2024

Conversation

HamzaIsrar12
Copy link
Contributor

@HamzaIsrar12 HamzaIsrar12 commented Jun 20, 2024

Description

LEARNER-10041

We have introduced the Fullstory Analytics Provider, which includes three main methods:

Identify: This method identifies the user by passing a userID (uid). Additionally, it includes a displayName for use on the Fullstory dashboard.

Event: This method records custom app events.

Page: This method functions similarly to a screen event, tracking page views.

Config:

FULLSTORY:
  ENABLED: false
  ORG_ID: ''

References:

@volodymyr-chekyrta
Copy link
Contributor

To flag, we can merge it for now.
But it's not a widely used instrument, it will be removed from the Open edX repo and should be used as a plug-in in the future.

@omerhabib26
Copy link
Contributor

Reviewing

Copy link
Contributor

@omerhabib26 omerhabib26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only some minor nits,
Some test cases are failing in VideoUnitViewModelTest.kt

We have introduced the Fullstory Analytics Provider, which includes
three main methods:

Identify: This method identifies the user by passing a userID (uid).
Additionally, it includes a displayName for use on the Fullstory
dashboard.

Event: This method records custom app events.

Page: This method functions similarly to a screen event, tracking
page views.

Fixes: LEARNER-10041
Fixes: LEARNER-10041
Fixes: LEARNER-10041
Fixes: LEARNER-10041
Fixes: LEARNER-10041
Fixes: LEARNER-10041
Fixes: LEARNER-10041
Fixes: LEARNER-10041
Fixes: LEARNER-10041
@volodymyr-chekyrta volodymyr-chekyrta merged commit 6efdd76 into openedx:develop Jul 9, 2024
4 checks passed
@HamzaIsrar12 HamzaIsrar12 deleted the hamza/LEARNER-10041 branch August 5, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants