-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Fullstory Analytics SDK Implementation #347
Merged
volodymyr-chekyrta
merged 11 commits into
openedx:develop
from
HamzaIsrar12:hamza/LEARNER-10041
Jul 9, 2024
Merged
feat: Fullstory Analytics SDK Implementation #347
volodymyr-chekyrta
merged 11 commits into
openedx:develop
from
HamzaIsrar12:hamza/LEARNER-10041
Jul 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HamzaIsrar12
requested review from
volodymyr-chekyrta,
k1rill,
dixidroid and
omerhabib26
June 20, 2024 22:57
To flag, we can merge it for now. |
Reviewing |
omerhabib26
requested changes
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only some minor nits,
Some test cases are failing in VideoUnitViewModelTest.kt
auth/src/main/java/org/openedx/auth/presentation/logistration/LogistrationViewModel.kt
Outdated
Show resolved
Hide resolved
auth/src/main/java/org/openedx/auth/presentation/signin/SignInViewModel.kt
Outdated
Show resolved
Hide resolved
auth/src/main/java/org/openedx/auth/presentation/signup/SignUpViewModel.kt
Outdated
Show resolved
Hide resolved
course/src/main/java/org/openedx/course/presentation/unit/video/VideoUnitFragment.kt
Outdated
Show resolved
Hide resolved
dashboard/src/main/java/org/openedx/learn/presentation/LearnViewModel.kt
Outdated
Show resolved
Hide resolved
We have introduced the Fullstory Analytics Provider, which includes three main methods: Identify: This method identifies the user by passing a userID (uid). Additionally, it includes a displayName for use on the Fullstory dashboard. Event: This method records custom app events. Page: This method functions similarly to a screen event, tracking page views. Fixes: LEARNER-10041
Fixes: LEARNER-10041
Fixes: LEARNER-10041
Fixes: LEARNER-10041
Fixes: LEARNER-10041
Fixes: LEARNER-10041
Fixes: LEARNER-10041
Fixes: LEARNER-10041
Fixes: LEARNER-10041
Fixes: LEARNER-10041
Fixes: LEARNER-10041
HamzaIsrar12
force-pushed
the
hamza/LEARNER-10041
branch
from
July 3, 2024 08:41
5d9b87e
to
9a835fe
Compare
omerhabib26
approved these changes
Jul 3, 2024
volodymyr-chekyrta
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LEARNER-10041
We have introduced the Fullstory Analytics Provider, which includes three main methods:
Identify: This method identifies the user by passing a userID (uid). Additionally, it includes a displayName for use on the Fullstory dashboard.
Event: This method records custom app events.
Page: This method functions similarly to a screen event, tracking page views.
Config:
References: