Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop to main. Release v2 #399

Merged
merged 58 commits into from
Nov 11, 2024
Merged

Develop to main. Release v2 #399

merged 58 commits into from
Nov 11, 2024

Conversation

PavloNetrebchuk
Copy link
Contributor

@PavloNetrebchuk PavloNetrebchuk commented Nov 6, 2024 •
edited
Loading

Features

  • Moved certificate access on course home (#321)
  • Calendar main screen and dialogs (#322)
  • Improved Dashboard level navigation (#308)
  • Add external router for deep links (#320)
  • Branch deep links to local calendar events (#249)
  • Atlas push-pull scripts (#317)
  • FCM integration for push notifications (#344)
  • Handle Branch deep links from Braze push notifications (#353)
  • FullStory Analytics SDK implementation (#347)
  • Calendar synchronization (#330)
  • xBlock offline mode (#346)
  • Relative dates display (#367)
  • Add flag to remove registration (#387)
  • Update primary course on learn tab (#389)
  • App-level error handling for WebView and network (#392)
  • Course-level error handling for empty states (#393)
  • Foundation library and analytics plugin (#395)

Fixes

  • Ensure cookies authentication before webview loads (#312)
  • Crash on restoring app after inactivity (#290)
  • Accessibility issue on course dashboard (#327)
  • UI issues on auth screens (#332)
  • Fix secondary course view button behavior (#345)
  • Update keyboard visibility and IME action (#350)
  • Video subtitles in native and YouTube player (#349)
  • Missing email in Facebook login (#377)
  • Crash when opening course from DashboardListFragment (#336)
  • IllegalStateException in fragment transactions (#373)
  • Various bug fixes from bug bash (#390)

Chores & Maintenance

  • Enhance app theme for edX branding (#262)
  • Plural validation in strings.xml (#348)
  • Remove Ukrainian translations from code (#342)
  • Code refactoring and JUnit tests (#391)

HamzaIsrar12 and others added 30 commits May 6, 2024 16:38
@HamzaIsrar12
fix: Ensure cookies authentication prior to webview loading (#312)
223fc43 
Ensure cookies' expiry time is verified before loading a webview.
Additionally, addressed a race condition within the
`clearWebViewCookie` method. This race condition caused the
premature reset of `authSessionCookieExpiration` to -1 due to delays
in the callback execution.

Fixes: LEARNER-9891
@dixidroid
fix: crash when restoring the app after a long period of inactivity
498f0ef
@volodymyr-chekyrta
Merge pull request #290 from touchapp/fix/crash_when_restore
ae777dd 
fix: crash when restoring the app after a long period of inactivity
@volodymyr-chekyrta
feat: Course home. Moved certificate access.
4d78460
@volodymyr-chekyrta
Merge pull request #321 from raccoongang/feature/course_home_certificate
f7d4d5f 
feat: [FC-0047] move the certificate view from the banner to the message section
@farhan-arshad-dev
chore: enhance app theme capability for prod edX theme/branding (#262)
a712170 
chore: enhance app theme capability for prod edX theme/branding

- Integrate Program config updates
- theming/branding code improvements for light and dark modes
- Force dark mode for the WebView (beta version)
- No major change in the Open edX theme

fixes: LEARNER-9783
@PavloNetrebchuk
feat: [FC-0047] Calendar main screen and dialogs (#322)
0d093ea 
* feat: Created calendar setting screen

* feat: CalendarAccessDialog

* feat: NewCalendarDialog

* fix: Fixes according to PR feedback
@PavloNetrebchuk
feat: [FC-0047] Improved Dashboard Level Navigation (#308)
c2684f9 
* feat: Created Learn screen. Added course/program navigation. Added endpoint for UserCourses screen.

* feat: Added primary course card

* feat: Added start/resume course button

* feat: Added alignment items

* feat: Fix future assignment date, add courses list, add onSearch and onCourse clicks

* feat: Add feature flag for enabling new/old dashboard screen, add UserCoursesScreen onClick methods

* feat: Create AllEnrolledCoursesFragment. Add endpoint parameters

* feat: AllEnrolledCoursesFragment UI

* feat: Minor code refactoring, show cached data if no internet connection

* feat: UserCourses screen data caching

* feat: Dashboard

* refactor: Dashboard type flag change, start course button change

* feat: Added programs fragment to LearnFragment viewPager

* feat: Empty states and settings button

* fix: Number of courses

* fix: Minor UI changes

* fix: Fixes according to designer feedback

* fix: Fixes after demo

* refactor: Move CourseContainerTab

* fix: Fixes according to PR feedback

* fix: Fixes according to PR feedback

* feat: added a patch from Omer Habib

* fix: Fixes according to PR feedback
@omerhabib26
fix: update config parsing structure (#319)
3df3c05 
fix: update config parsing structure

- Update dictionary for ProgramConfig
- Update UI related feature flags under a single Key
- fix image load in course

fix: LEARNER-9891

* fix: Updated minor fix
@omerhabib26
feat: delete old videos Directory (#326)
3e95560 
feat: delete old videos Directory

- Delete all the videos and folders of old app

fix: LEARNER-9950
@omerhabib26
fix: Accessibility issue on courseDashboard (#327)
22ee176 
- added content description for views
fix: LEARNER-10021
@PavloNetrebchuk @volodymyr-chekyrta @farhan-arshad-dev
feat: [FC-0047] Course progress and collapsing sections (#323)
1bc1d4c 
* feat: Course Home progress bar

* feat: Collapsing course sections

* feat: New download icons

* feat: show CourseContainerFragment if COURSE_NESTED_LIST_ENABLED false

* fix: course progress bar updating

* feat: Renamed COURSE_NESTED_LIST_ENABLE feature flag

* feat: Course home. Moved certificate access.

* chore: enhance app theme capability for prod edX theme/branding (#262)

chore: enhance app theme capability for prod edX theme/branding

- Integrate Program config updates
- theming/branding code improvements for light and dark modes
- Force dark mode for the WebView (beta version)
- No major change in the Open edX theme

fixes: LEARNER-9783

* feat: [FC-0047] Calendar main screen and dialogs (#322)

* feat: Created calendar setting screen

* feat: CalendarAccessDialog

* feat: NewCalendarDialog

* fix: Fixes according to PR feedback

* fix: DiscussionTopicsViewModelTest.kt jUnit test

* fix: assignment dates

* feat: [FC-0047] Improved Dashboard Level Navigation (#308)

* feat: Created Learn screen. Added course/program navigation. Added endpoint for UserCourses screen.

* feat: Added primary course card

* feat: Added start/resume course button

* feat: Added alignment items

* feat: Fix future assignment date, add courses list, add onSearch and onCourse clicks

* feat: Add feature flag for enabling new/old dashboard screen, add UserCoursesScreen onClick methods

* feat: Create AllEnrolledCoursesFragment. Add endpoint parameters

* feat: AllEnrolledCoursesFragment UI

* feat: Minor code refactoring, show cached data if no internet connection

* feat: UserCourses screen data caching

* feat: Dashboard

* refactor: Dashboard type flag change, start course button change

* feat: Added programs fragment to LearnFragment viewPager

* feat: Empty states and settings button

* fix: Number of courses

* fix: Minor UI changes

* fix: Fixes according to designer feedback

* fix: Fixes after demo

* refactor: Move CourseContainerTab

* fix: Fixes according to PR feedback

* fix: Fixes according to PR feedback

* feat: added a patch from Omer Habib

* fix: Fixes according to PR feedback

* fix: Assignment date string

* fix: Lint error

* fix: Assignment date string

* fix: Fixes according to PR feedback

* fix: Fixes according to designer feedback

* fix: Fixes according to PR feedback

---------

Co-authored-by: Volodymyr Chekyrta <volodymyr.chekyrta@raccoongang.com>
Co-authored-by: Farhan Arshad <43750646+farhan-arshad-dev@users.noreply.github.com>
@omerhabib26
fix: enable Programs view for new dashboard navigation (#328)
09b422a 
- Update/optimise ProgramFragment
- enable ProgramFragment for both dashboards(list/gallery)
- hide dropdown on Learn Tab if programs not available

fix: LEARNER-10035
@PavloNetrebchuk
fix: Filter block IDs before download, minor refactoring (#333)
7d623ce
@PavloNetrebchuk
fix: Update feature flag name (#334)
651db4c
@volodymyr-chekyrta
fix: sourceSets dir fallback (#335)
21bd1a1
@omerhabib26
fix: Crash on opening a course from DashboardListFragment (#336)
07f6dca 
- Replace the fragmentManager of parentFragment with activity

fix: LEARNER-10035
@dixidroid
feat: added the external router for deep links (#320)
d845e5e
@HamzaIsrar12
fix: UI Issues on Auth Screens (#332)
5c887eb 
- feat: Add password visibility toggle to the password fields  
- fix: Autofill the "Full Name" and "Email" fields with SSO data
- refactor: Redesign the modal that appears after SSO

Fixes: Issue#331
@HamzaIsrar12
feat: Add Branch deep links to local calendar events (#249)
efd3998 
- Add branch deep links to Calendar Events
- Resolved Calendar Dialogs Issue Caused by Permission Launcher

Fixes: LEARNER-9795
@Amr-Nash
feat: atlas push pull scripts: FC-55 (#317)
065d583
@OmarIthawi
fix: English plurals error in transifex should be one and other (#…
dbd02e3 
…341)
@volodymyr-chekyrta
fix: secondary courses view all button behavior (#345)
05c3544
@OmarIthawi
chore: validate plurals in strings.xml | FC-55 (#348)
7ff0ff4 
* chore: validate plurals in strings.xml

* fix: more plurals fixes on English
@volodymyr-chekyrta
feat: [FC-0047] FCM (#344)
948277a 
* feat: fcm

* fix: address feedback
@omerhabib26
fix: update keyboard visibility and imeAction (#350)
5abf44d 
* fix: update keyboard visibility and imeAction

- Hide keyboard on logistration screens
- update imeAction for long InputEditFields

-LEARNER-10032

* fix: Added error Text for editable fields on SignIn Screen

- Add error text in case of empty fields on sign in Screen

fix: LEARNER-10032

* fix: Address PR comments
@dixidroid
fix: show only one screen with all downloadable content (#352)
ba305a0
@HamzaIsrar12
fix: Video Subtitles on Native and Youtube Player (#349)
02a83ed 
* fix: Video Subtitles on Native and Youtube Player

* chore: UI Changes
@HamzaIsrar12
feat: Handle Branch Deeplinks from Braze Push Notification (#353)
9f0740f 
* feat: Handle Branch Deeplinks from Braze Push Notification

Fixes: LEARNER-10054

* refactor: Update class name to BranchBrazeDeeplinkHandler
@HamzaIsrar12
feat: Fullstory Analytics SDK Implementation (#347)
6efdd76 
* feat: Fullstory Analytics SDK Implementation

We have introduced the Fullstory Analytics Provider, which includes
three main methods:

Identify: This method identifies the user by passing a userID (uid).
Additionally, it includes a displayName for use on the Fullstory
dashboard.

Event: This method records custom app events.

Page: This method functions similarly to a screen event, tracking
page views.

Fixes: LEARNER-10041

* feat: Add screen event method to the Analytics Manager

Fixes: LEARNER-10041

* fix: Course Home Tabs Events

Fixes: LEARNER-10041

* chore: Discovery Screen Events

Fixes: LEARNER-10041

* chore: Main Dashboard Screen Events

Fixes: LEARNER-10041

* chore: Auth Screen Events

Fixes: LEARNER-10041

* chore: Profile Screen Events

Fixes: LEARNER-10041

* chore: Course Screen Events

Fixes: LEARNER-10041

* fix: PLS Banner Multiple Events

Fixes: LEARNER-10041

* chore: Logistration Screen Event

Fixes: LEARNER-10041

* refactor: Optimize code

Fixes: LEARNER-10041
PavloNetrebchuk and others added 22 commits September 11, 2024 12:09
@PavloNetrebchuk
feat: [FC-0047] Relative Dates (#367)
4c1a909 
* feat: relative dates

* fix: Fixes according to designer feedback
@dixidroid
fix: Handle missing email in Facebook login (#377)
1dc72d2
@dixidroid @farhan-arshad-dev
fix: IllegalStateException on `supportFragmentManager.popBackStack(…
f66b3f2 
…)` (#379)

- Ensure `MutableStateFlow` is lifecycle-aware by utilizing `collectAsStateWithLifecycle`.

Co-authored-by: Farhan Arshad <farshad@2u.com>
@dixidroid @farhan-arshad-dev
fix: disable full story plugin when disabled (#381)
77cdf41 
Co-authored-by: Farhan Arshad <farshad@2u.com>
@dixidroid
fix: bug when unable to see new loaded items on the All Courses screen (
eddd54b 
#382)
@dixidroid @HamzaIsrar12
fix: Auto Playing Videos and Discovery's External Browser Pop-Up (#383)
660770c 
* fix: Open in External Browser Pop-Up for Bachelor's Degrees

* fix: Multiple videos playing simultaneously

* fix: Retain Video Seek Time when Exiting Fullscreen in Native Videos

---------

Co-authored-by: Hamza Israr <hamzaisrar12@gmail.com>
@dixidroid
fix: wrong sending custom or track events as page events (#384)
a86d95d
@dixidroid
fix: ignore IllegalStateException when fragment transaction fails (#373)
42f5835
@dixidroid
fix: crash when internet disconnected right after opening a course (#376
16a3b17 
)
@dixidroid @omerhabib26
fix: Update course dates prefix on course cards (#380)
a8b7395 
Co-authored-by: omer.habib <omer.habib26@gmail.com>
@PavloNetrebchuk
refactor: Rename EnrollmentStatus field (#385)
bbf71e3
@PavloNetrebchuk
refactor: Reorganize offline logic for better readability (#386)
1daedbe
@xitij2000
fix: Support pull to refresh for empty dashboard (#375)
e2ee565 
This change adds support for pull to refresh when the course list is empty.
@dixidroid
fix: Remove student_view_mutli_device dependency for HTML XBlocks (#388)
aaefaa4
@kaustavb12
feat: add flag to remove registration from app (#387)
0de8db1
@dixidroid
feat: added ability update the primary course on the learn tab (#389)
44f106d
@dixidroid
fix: Minor bugbash fixes (#390)
0ff62f0
@PavloNetrebchuk
Code refactoring and junit tests (#391)
190dd87 
* refactor: minor code style changes

* feat: CalendarViewModelTest

* feat: LearnViewModelTest
@dixidroid @farhan-arshad-dev
feat: App Level WebView/No Internet Error Handling (#392)
2839535 
Co-authored-by: Farhan Arshad <43750646+farhan-arshad-dev@users.noreply.github.com>
@dixidroid @farhan-arshad-dev
feat: Course Level Error Handling for Empty States (#393)
a4eac8d 
Co-authored-by: Farhan Arshad <43750646+farhan-arshad-dev@users.noreply.github.com>
@dixidroid
fix: bug when unable to see downloaded html content (#396)
a005e85
@PavloNetrebchuk
feat: foundation lib and analytic plugin implementation (#395)
e61523e
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 6, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @PavloNetrebchuk!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/openedx-mobile-maintainers. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@volodymyr-chekyrta volodymyr-chekyrta changed the title Develop Develop to main. Release v2 Nov 6, 2024
volodymyr-chekyrta and others added 2 commits November 8, 2024 12:21
@volodymyr-chekyrta
build: update action versions (#401)
773dac5
@dixidroid @omerhabib26
feat: added ability to handle course errors (#397)
88dfc54 
* fix: bug when unable to see downloaded html content

* feat: added ability to handle course errors

---------

Co-authored-by: Omer Habib <30689349+omerhabib26@users.noreply.github.com>
@volodymyr-chekyrta volodymyr-chekyrta merged commit 1fe8ee4 into main Nov 11, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volodymyr-chekyrta volodymyr-chekyrta volodymyr-chekyrta approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.