Skip to content

Commit

Permalink
feat: remove uk translations and sync xcode project after `pull_trans…
Browse files Browse the repository at this point in the history
…lations` (#465)
  • Loading branch information
OmarIthawi authored Aug 19, 2024
1 parent 73e6175 commit 157ded7
Show file tree
Hide file tree
Showing 23 changed files with 338 additions and 659 deletions.
49 changes: 49 additions & 0 deletions .github/workflows/validate-translations.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
name: Test Makefile

on:
workflow_dispatch:

push:
branches: [ develop ]

pull_request:

jobs:
translations:
name: "${{ matrix.case.name }}"
runs-on: macos-14

strategy:
matrix:
case:
- name: clean_translations
command: |
make clean_translations;
- name: extract_translations
command: |
make extract_translations;
echo "Ensure combined localization file exists";
test -f I18N/I18N/en.lproj/Localizable.strings;
- name: pull_translations
command:
make pull_translations;
echo "Files are split properly";
test -f Authorization/Authorization/uk.lproj/Localizable.strings;

steps:
- uses: nschloe/action-cached-lfs-checkout@v1.2.1
with:
ref: ${{ github.event.pull_request.head.sha }}

- name: Use Python
uses: actions/setup-python@v5
with:
python-version: 3.11

- name: Install translations requirements
run: make translation_requirements

- name: "${{ matrix.case.name }}"
run: "${{ matrix.case.command }}"
2 changes: 0 additions & 2 deletions Authorization/Authorization.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@
025F40E129D360E20064C183 /* ResetPasswordViewModel.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ResetPasswordViewModel.swift; sourceTree = "<group>"; };
02A2ACDA2A4B016100FBBBBB /* AuthorizationAnalytics.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AuthorizationAnalytics.swift; sourceTree = "<group>"; };
02E0618329DC2373006E9024 /* ResetPasswordViewModelTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ResetPasswordViewModelTests.swift; sourceTree = "<group>"; };
02ED50CC29A64B90008341CD /* uk */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = uk; path = uk.lproj/Localizable.strings; sourceTree = "<group>"; };
02F3BFE4292533720051930C /* AuthorizationRouter.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AuthorizationRouter.swift; sourceTree = "<group>"; };
071009C628D1DA4F00344290 /* SignInViewModel.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SignInViewModel.swift; sourceTree = "<group>"; };
07169454296D913300E3DED6 /* AuthorizationTests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = AuthorizationTests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };
Expand Down Expand Up @@ -528,7 +527,6 @@
isa = PBXVariantGroup;
children = (
0770DE6C28D0C035006D8A5D /* en */,
02ED50CC29A64B90008341CD /* uk */,
);
name = Localizable.strings;
sourceTree = "<group>";
Expand Down
49 changes: 0 additions & 49 deletions Authorization/Authorization/uk.lproj/Localizable.strings

This file was deleted.

2 changes: 0 additions & 2 deletions Core/Core.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,6 @@
02EBC7562C19DCDB00BE182C /* SyncStatus.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SyncStatus.swift; sourceTree = "<group>"; };
02EBC7582C19DE1100BE182C /* CalendarManagerProtocol.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CalendarManagerProtocol.swift; sourceTree = "<group>"; };
02EBC75A2C19DE3D00BE182C /* CourseForSync.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CourseForSync.swift; sourceTree = "<group>"; };
02ED50CB29A64B84008341CD /* uk */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = uk; path = uk.lproj/Localizable.strings; sourceTree = "<group>"; };
02F164362902A9EB0090DDEF /* StringExtension.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = StringExtension.swift; sourceTree = "<group>"; };
02F6EF3A28D9B8EC00835477 /* CourseCellView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CourseCellView.swift; sourceTree = "<group>"; };
02F6EF4928D9F0A700835477 /* DateExtension.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = DateExtension.swift; sourceTree = "<group>"; };
Expand Down Expand Up @@ -1293,7 +1292,6 @@
isa = PBXVariantGroup;
children = (
0770DE5C28D0B209006D8A5D /* en */,
02ED50CB29A64B84008341CD /* uk */,
);
name = Localizable.strings;
sourceTree = "<group>";
Expand Down
127 changes: 0 additions & 127 deletions Core/Core/uk.lproj/Localizable.strings

This file was deleted.

6 changes: 2 additions & 4 deletions Course/Course.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,6 @@
02D4FC2D2BBD7C9C00C47748 /* MessageSectionView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MessageSectionView.swift; sourceTree = "<group>"; };
02E3803D2BFF9F0A00815AFA /* CourseProgressView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CourseProgressView.swift; sourceTree = "<group>"; };
02EBC7542C19CFCF00BE182C /* CalendarSyncStatusView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CalendarSyncStatusView.swift; sourceTree = "<group>"; };
02ED50CF29A64BB6008341CD /* uk */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = uk; path = uk.lproj/Localizable.strings; sourceTree = "<group>"; };
02F0144E28F46474002E513D /* CourseContainerView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CourseContainerView.swift; sourceTree = "<group>"; };
02F0145628F4A2FF002E513D /* CourseContainerViewModel.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CourseContainerViewModel.swift; sourceTree = "<group>"; };
02F3BFDC29252E900051930C /* CourseRouter.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CourseRouter.swift; sourceTree = "<group>"; };
Expand Down Expand Up @@ -309,8 +308,8 @@
02B6B3B828E1D12900232911 /* Data */,
02B6B3B528E1D10700232911 /* Domain */,
02EAE2CA28E1F0A700529644 /* Presentation */,
97CA95212B875EA200A9EDEA /* Views */,
97EA4D822B84EFA900663F58 /* Managers */,
97CA95212B875EA200A9EDEA,
97EA4D822B84EFA900663F58,
02B6B3B428E1C49400232911 /* Localizable.strings */,
02C355372C08DCD700501342 /* Localizable.stringsdict */,
);
Expand Down Expand Up @@ -937,7 +936,6 @@
isa = PBXVariantGroup;
children = (
02B6B3B328E1C49400232911 /* en */,
02ED50CF29A64BB6008341CD /* uk */,
);
name = Localizable.strings;
sourceTree = "<group>";
Expand Down
Loading

0 comments on commit 157ded7

Please sign in to comment.