chore: add show progress param to web browser

openedx · Dec 14, 2023 · fec2fc2 · fec2fc2
1 parent 7196b2b
commit fec2fc2
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/Core/Core/View/Base/WebBrowser.swift b/Core/Core/View/Base/WebBrowser.swift
@@ -11,23 +11,25 @@ import Theme
 
 public struct WebBrowser: View {
 
-    var url: String
-    var pageTitle: String
-
-    @State private var isShowProgress: Bool = true
+    @State private var isLoading: Bool = true
     @Environment(\.presentationMode) var presentationMode
+
+    private var url: String
+    private var pageTitle: String
+    private var showProgress: Bool
 
-    public init(url: String, pageTitle: String) {
+    public init(url: String, pageTitle: String, showProgress: Bool = false) {
         self.url = url
         self.pageTitle = pageTitle
+        self.showProgress = showProgress
     }
 
     public var body: some View {
         GeometryReader { proxy in
             ZStack(alignment: .center) {
                 Theme.Colors.background.ignoresSafeArea()
                 webView(proxy: proxy)
-                if isShowProgress {
+                if isLoading, showProgress {
                     HStack(alignment: .center) {
                         ProgressBar(
                             size: 40,
@@ -52,7 +54,7 @@ public struct WebBrowser: View {
             )
             WebView(
                 viewModel: .init(url: url, baseURL: ""),
-                isLoading: $isShowProgress,
+                isLoading: $isLoading,
                 refreshCookies: {}
             )
         }

diff --git a/Profile/Profile/Presentation/Profile/Subviews/ProfileSupportInfoView.swift b/Profile/Profile/Presentation/Profile/Subviews/ProfileSupportInfoView.swift
@@ -98,7 +98,8 @@ struct ProfileSupportInfoView: View {
         NavigationLink {
             WebBrowser(
                 url: viewModel.url.absoluteString,
-                pageTitle: viewModel.title
+                pageTitle: viewModel.title,
+                showProgress: true
             )
         } label: {
             HStack {