Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] FAQ #119

Closed
Tracked by #117
nizmaylova opened this issue Oct 22, 2023 · 7 comments · Fixed by #198
Closed
Tracked by #117

[iOS] FAQ #119

nizmaylova opened this issue Oct 22, 2023 · 7 comments · Fixed by #198
Assignees

Comments

@nizmaylova
Copy link

nizmaylova commented Oct 22, 2023

Need to add FAQ

Image

@moiz994
Copy link

moiz994 commented Dec 12, 2023

Acceptance Criteria:

  • Tapping the FAQ button should redirect the user to the mobile browser to a specified webpage
  • Webpage is URL is configurable and maintained in the app config
  • This should be implemented behind a feature flag

@rnr
Copy link
Contributor

rnr commented Dec 13, 2023

@moiz994
"Tapping the FAQ button should redirect the user to the mobile browser to a specified webpage"
do you mean here in the app webpage or external mobile browser (Safari app)?
thank you

@moiz994
Copy link

moiz994 commented Dec 13, 2023

@rnr the external mobile browser.

@rnr
Copy link
Contributor

rnr commented Dec 13, 2023

@moiz994 Do we get any benefits from using an external browser instead of a webView in the application? Thank you

@moiz994
Copy link

moiz994 commented Dec 13, 2023

@rnr good question, right now this is the legacy functionality that we're targeting to be in parity with before launch. There isn't any special benefit other than that this page is not optimized for webview currently so we direct the user to the mobile browser.

@rnr
Copy link
Contributor

rnr commented Dec 13, 2023

Screenshot 2023-12-13 at 18 58 58 @moiz994 The page is not optimized for viewing in the web version of the app or for mobile Safari. If no difference then do you think we still need to redirect outside? cc @touchapp @marcotuts

@moiz994
Copy link

moiz994 commented Dec 14, 2023

@rnr thanks for sharing these screenshots. As you can see this page has a header where it shows the breadcrumbs, if this URL is implemented as a webview in the app, the users can start exploring almost the whole edX website within the app. The web team usually removes headers and footers for us and provides a URL for webviews for the app. Since we don't have one for this page ready, we need to direct the user to the browser for this page.
Maybe after the MVP we can look at bringing this in as native content but for now, let's focus on parity.

cc: @miankhalid

@rnr rnr linked a pull request Dec 14, 2023 that will close this issue
@rnr rnr closed this as completed Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants