Verticals popup menu on CourseUnitView #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forgotvas
requested review from
saeedbashir,
shafqatfarhan and
volodymyr-chekyrta
and removed request for
saeedbashir and
shafqatfarhan
|
@touchapp should we start the review of this PR or wait for:
|
| private let landscapeTopSpacing: CGFloat = 75 | ||
|
|
||
| let isDropdownActive: Bool = { | ||
| Container.shared.resolve(ConfigProtocol.self)?.uiComponents.isVerticalsMenuEnabled ?? false |
There was a problem hiding this comment.
Would be better to pass this as an argument to the initializer or use ConfigProtocol from the viewModel
| @@ -180,4 +180,21 @@ public class CourseUnitViewModel: ObservableObject { | |||
| func trackFinishVerticalBackToOutlineClicked() { | |||
| analytics.finishVerticalBackToOutlineClicked(courseId: courseID, courseName: courseName) | |||
| } | |||
|
|
|||
| func route(to vertical: CourseVertical) { | |||
| if let index = verticals.firstIndex(where: {$0.id == vertical.id}), | |||
There was a problem hiding this comment.
Small improvement for readability
verticals.firstIndex(where: {$0.id == vertical.id}) -> verticals.firstIndex(where: { $0.id == vertical.id })
|
Great feature! |
|
fixed merge conflict and corrected code according @volodymyr-chekyrta comments |
volodymyr-chekyrta
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added verticals popup menu to CourseUnitView. It closed by feature key
VERTICALS_MENU_ENABLEDofUI_COMPONENTScategory, to test it need to use config from Config PR #157.This issue related to: #156
Sample with key
Simulator.Screen.Recording.-.iPhone.15.-.2023-12-06.at.16.37.10.mp4
Sample with disabled or without key
Simulator.Screen.Recording.-.iPhone.15.-.2023-12-06.at.16.36.25.mp4