Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS - Differences between the FAQ section on the new app and the FAQ section on the market-built app #233

Closed
hassan6190 opened this issue Jan 15, 2024 · 3 comments · Fixed by #273
Closed

iOS - Differences between the FAQ section on the new app and the FAQ section on the market-built app #233

hassan6190 opened this issue Jan 15, 2024 · 3 comments · Fixed by #273
Assignees
@eyatsenkoperpetio
Labels
bug Report of or fix for something that isn't working as intended

Comments

@hassan6190
Copy link

Description:
Profile screen > On the new app, the FAQ section shows a text (FAQ) whereas on the market build section, the FAQ section shows the text (View FAQ)

Expected Behaviour:
The FAQ section on both apps (New and Market build) should show the text "View FAQ"
Improvement
@hassan6190 hassan6190 added the bug Report of or fix for something that isn't working as intended label Jan 15, 2024
@rnr
Copy link
Contributor

rnr commented Jan 16, 2024

@hassan6190
I'm not sure we need to add 'View' to 'FAQ' string because it has disclosure arrow now. @moiz994 could you check this from UX/design side please?
Thank you

@moiz994
Copy link

moiz994 commented Jan 16, 2024 •
edited
Loading

@hassan6190 I'm not sure we need to add 'View' to 'FAQ' string because it has disclosure arrow now. @moiz994 could you check this from UX/design side please? Thank you

Can you please confirm if the new app is opening the FAQ page within the app or external browser? If it's leading to the external browser then it would be best to replicate the market build behavior.

@rnr
Copy link
Contributor

rnr commented Jan 16, 2024

@moiz994 You are right - it opens in external. Ok let's change the string. Thank you.

@hassan6190 hassan6190 changed the title Differences between the FAQ section on the new app and the FAQ section on the market-built app iOS - Differences between the FAQ section on the new app and the FAQ section on the market-built app Jan 17, 2024
@eyatsenkoperpetio eyatsenkoperpetio mentioned this issue Feb 5, 2024
Merged
@eyatsenkoperpetio eyatsenkoperpetio linked a pull request Feb 5, 2024 that will close this issue
EULA link and checkbox for "send marketing messages" #273
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyatsenkoperpetio eyatsenkoperpetio

Labels
bug Report of or fix for something that isn't working as intended
Projects
Open edX Mobile Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

EULA link and checkbox for "send marketing messages" touchapp/openedx-app-ios
4 participants
@rnr @hassan6190 @eyatsenkoperpetio @moiz994