Course bars: Download videos to device and Select download quality bars #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uality # Conflicts: # Course/Course/SwiftGen/Strings.swift # Course/Course/en.lproj/Localizable.strings # Course/Course/uk.lproj/Localizable.strings
# Conflicts: # Course/Course/Presentation/Outline/ContinueWithView.swift # Profile/Profile.xcodeproj/project.pbxproj
# Conflicts: # Course/Course.xcodeproj/project.pbxproj # Course/Course/Data/CourseRepository.swift
saeedbashir
requested changes
Jan 31, 2024
rnr
previously approved these changes
Jan 31, 2024
| @@ -62,6 +62,7 @@ | |||
| "SETTINGS.WIFI_TITLE" = "Тільки Wi-fi"; | |||
| "SETTINGS.WIFI_DESCRIPTION" = "Завантажувати відео, лише коли Wi-Fi увімкнено"; | |||
| "SETTINGS.VIDEO_QUALITY_TITLE" = "Якість потокового відео"; | |||
| "SETTINGS.VIDEO_DOWNLOAD_QUALITY_TITLE" = "Video download quality"; | |||
There was a problem hiding this comment.
@eyatsenkoperpetio should we add the same in en.lproj?
| try await manager.cancelDownloading(task: task) | ||
| downloads.removeAll(where: { $0.id == task.id }) | ||
| } catch { | ||
| print(error) |
There was a problem hiding this comment.
@eyatsenkoperpetio could you use debugLog here instead please?
OpenEdX/Data/CorePersistence.swift
Outdated
| for record in records { | ||
| context.delete(record) | ||
| try context.save() | ||
| print("File erased successfully") |
There was a problem hiding this comment.
@eyatsenkoperpetio could you use debugLog here instead please?
eyatsenkoperpetio
dismissed stale reviews from rnr and saeedbashir
via
f7f1ad5
eyatsenkoperpetio
requested review from
volodymyr-chekyrta,
rnr,
saeedbashir and
sergeymomot
and removed request for
sergeymomot
rnr
approved these changes
Feb 1, 2024
saeedbashir
approved these changes
Feb 1, 2024
volodymyr-chekyrta
approved these changes
Feb 1, 2024
|
Ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Progress Downloads View #166
The user can view the download statuses or the number of downloads in the Download Progress section.
Add notification about downloading a large video #167
Need to add notification about downloading a large video.
Bulk Download of Course Videos #168
Add the option to download all videos at once on the video tab.
Add an controller to select Quality of the downloadable video #217
User should be able to choose the quality of the downloadable video. Roughly the way it is implemented in the current application (this controller can be opened from course -> videos and from users Profile)
Add download pause/resume action after collapse/expand the app #228
Add auto pause/resume action for downloadable content after collapse and expand the app.
Add ability to open and download currently unsupported videos #229
find out the reason why these videos are not open
find out how to download this content for offline mode
Screen.Recording.2024-01-17.at.14.13.11.mov