Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whats new page hidding #245

Closed
wants to merge 6 commits into from
Closed

Conversation

rnr
Copy link
Contributor

@rnr rnr commented Jan 22, 2024

PR for #224
Added FF WHATS_NEW_IMAGE_OR_TITLE_TO_SKIP_PAGE - it can contain the image name or page title from the What's new JSON file. Pages with such image name or title will be skipped in the What's new function.
To test you can use this config https://github.com/edx/edx-mobile-config/tree/anton/whatsnew or add this to shared.yaml manually like:

UI_COMPONENTS:
    WHATS_NEW_IMAGE_OR_TITLE_TO_SKIP_PAGE: 'Learning Site Switching'

The process_config.py script has also been changed, it will now try to merge dictionaries from different files (e.g. iOS.yaml and shared.yaml) if both files have the same section with children in them

@rnr rnr linked an issue Jan 22, 2024 that may be closed by this pull request
forgotvas
forgotvas previously approved these changes Jan 22, 2024
@saeedbashir
Copy link
Contributor

@rnr As discussed over the huddle, this PR isn't needed as every version will be having it's own copy of whatsnew messages and images.

@rnr rnr closed this Jan 22, 2024
@rnr
Copy link
Contributor Author

rnr commented Jan 22, 2024

Looks like this should be resolved differently. Thanks to @saeedbashir for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants