[iOS] Prompt | Confirmation Alert Missing Before Deleting Section-Level Downloaded Videos #456 #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnr
previously approved these changes
Jun 14, 2024
shafqat-muneer
requested changes
Jun 14, 2024
| @@ -34,6 +34,7 @@ | |||
| "ALERT.DELETE_ALL_VIDEOS" = "Are you sure you want to delete all video(s) for"; | |||
| "ALERT.DELETE_VIDEOS" = "Are you sure you want to delete video(s) for"; | |||
| "ALERT.STOP_DOWNLOADING" = "Turning off the switch will stop downloading and delete all downloaded videos for"; | |||
| "ALERT.WARNING" = "Warning"; | |||
There was a problem hiding this comment.
Please also add same string for uk.lproj/Localizable.strings file.
There was a problem hiding this comment.
done, please check again
rnr
approved these changes
Jun 17, 2024
shafqat-muneer
approved these changes
Jun 20, 2024
|
Hi team, this functionality will soon be replaced with this one: Should we merge this PR? I'm good to merge |
volodymyr-chekyrta
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[iOS] Prompt | Confirmation Alert Missing Before Deleting Section-Level Downloaded Videos #456