chore: Fix Initial Accessibility Testing Issues #499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saeedbashir
reviewed
Jul 16, 2024
| @@ -86,7 +86,8 @@ | |||
| "SETTINGS.DOWNLOAD_QUALITY_720_DESCRIPTION" = "Best quality"; | |||
|
|
|||
| "DONE" = "Done"; | |||
| "VIEW " = "View"; | |||
| "VIEW" = "View"; | |||
| "BACK" = "back"; | |||
There was a problem hiding this comment.
how about using Back instead of back?
saeedbashir
reviewed
Jul 16, 2024
| @@ -86,7 +86,8 @@ | |||
| "SETTINGS.DOWNLOAD_QUALITY_720_DESCRIPTION" = "Best quality"; | |||
|
|
|||
| "DONE" = "Done"; | |||
| "VIEW " = "View"; | |||
| "VIEW" = "View"; | |||
| "BACK" = "back"; | |||
There was a problem hiding this comment.
how about using Back instead of back?
rnr
previously approved these changes
Jul 16, 2024
Core/Core/SwiftGen/Strings.swift
Outdated
| @@ -10,6 +10,8 @@ import Foundation | |||
| // swiftlint:disable explicit_type_interface function_parameter_count identifier_name line_length | |||
| // swiftlint:disable nesting type_body_length type_name vertical_whitespace_opening_braces | |||
| public enum CoreLocalization { | |||
| /// back | |||
| public static let back = CoreLocalization.tr("Localizable", "BACK", fallback: "back") | |||
There was a problem hiding this comment.
should we use capitalised 'B' here too?
|
We're closing this PR and moving these changes to our own fork, as they are critical for us. After our release, we hope to find a way to contribute these changes back, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LEARNER-10022: iOS - Fix Initial Accessibility Testing Issues