Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: atlas pull and push scripts | FC-55 #412

Closed
wants to merge 37 commits into from

Conversation

OmarIthawi
Copy link
Member

@OmarIthawi OmarIthawi commented Apr 22, 2024

Description

This pull request provides the CI scripts and developer tooling for the Atlas Translations Management Design
proposal related to OEP-58.

Testing instructions

Testing the pull_translations:

git rm '**/uk.lproj/Localizable.strings'
make ATLAS_OPTIONS='--repository=Zeit-Labs/openedx-translations --branch=fc_55_sample' pull_translations
git status

Testing the combine_translations:

TBD

Status

We'll merge to this pull request into this branch multiple pull requests. We'll keep this open until we're ready for review.

This pull request is useful to watch progress.

TODO

  • Fix the python3-localizable pip package for python3 compatibility
  • Install openedx-atlas in the virtual env
  • Refactor the code into a single Python script to improve code reuse
  • Add CI scripts for make extract_translations
  • Test with the iOS team (Volo and others)
  • Review by Brian Smith

Related issues

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 22, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Apr 22, 2024

Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@OmarIthawi OmarIthawi marked this pull request as ready for review April 26, 2024 13:56
@OmarIthawi OmarIthawi marked this pull request as draft April 26, 2024 13:56
@OmarIthawi OmarIthawi closed this May 3, 2024
@openedx-webhooks
Copy link

@OmarIthawi Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@OmarIthawi
Copy link
Member Author

Closed in favor of #422

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants