Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix Initial Accessibility Testing Issues #499

Closed
wants to merge 3 commits into from
Closed

chore: Fix Initial Accessibility Testing Issues #499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a421ee
chore: Fix Initial Accessibility Testing Issues
shafqat-muneer Jul 13, 2024
2e0570a
chore: adress review feedback
shafqat-muneer Jul 16, 2024
91c1f6a
chore: address review feedback
shafqat-muneer Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Core/Core/SwiftGen/Strings.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ import Foundation
// swiftlint:disable explicit_type_interface function_parameter_count identifier_name line_length
// swiftlint:disable nesting type_body_length type_name vertical_whitespace_opening_braces
public enum CoreLocalization {
/// Back
public static let back = CoreLocalization.tr("Localizable", "BACK", fallback: "Back")
/// Done
public static let done = CoreLocalization.tr("Localizable", "DONE", fallback: "Done")
/// View in Safari
Expand All @@ -21,7 +23,7 @@ public enum CoreLocalization {
/// Tomorrow
public static let tomorrow = CoreLocalization.tr("Localizable", "TOMORROW", fallback: "Tomorrow")
/// View
public static let view = CoreLocalization.tr("Localizable", "VIEW ", fallback: "View")
public static let view = CoreLocalization.tr("Localizable", "VIEW", fallback: "View")
/// Yesterday
public static let yesterday = CoreLocalization.tr("Localizable", "YESTERDAY", fallback: "Yesterday")
public enum Alert {
Expand Down
2 changes: 2 additions & 0 deletions Core/Core/View/Base/BackNavigationButton.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@ public struct BackNavigationButton: View {

public var body: some View {
BackNavigationButtonRepresentable(action: action, color: color, viewModel: viewModel)
.accessibilityIdentifier("back_button")
.accessibilityLabel(CoreLocalization.back)
.onAppear {
viewModel.loadItems()
}
Expand Down
3 changes: 2 additions & 1 deletion Core/Core/en.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,8 @@
"SETTINGS.DOWNLOAD_QUALITY_720_DESCRIPTION" = "Best quality";

"DONE" = "Done";
"VIEW " = "View";
"VIEW" = "View";
"BACK" = "Back";

"PICKER.SEARCH" = "Search";
"PICKER.ACCEPT" = "Accept";
Expand Down
2 changes: 2 additions & 0 deletions Core/Core/uk.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@
"SETTINGS.DOWNLOAD_QUALITY_720_DESCRIPTION" = "Best quality";

"DONE" = "Зберегти";
"VIEW" = "View";
"BACK" = "Back";

"PICKER.SEARCH" = "Знайти";
"PICKER.ACCEPT" = "Прийняти";
Expand Down
8 changes: 4 additions & 4 deletions Profile/Profile/Presentation/Settings/SettingsView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public struct SettingsView: View {
.resizable()
.edgesIgnoringSafeArea(.top)
}
.frame(maxWidth: .infinity, maxHeight: 200)
.frame(maxWidth: .infinity, maxHeight: 50)
.accessibilityIdentifier("auth_bg_image")

// MARK: - Page name
Expand Down Expand Up @@ -120,7 +120,7 @@ public struct SettingsView: View {
viewModel.router.showDatesAndCalendar()
}, label: {
HStack {
Text("Dates & Calendar") // TODO: add ProfileLocalization...
Text(ProfileLocalization.datesAndCalendar)
.font(Theme.Fonts.titleMedium)
Spacer()
Image(systemName: "chevron.right")
Expand All @@ -130,7 +130,7 @@ public struct SettingsView: View {

}
.accessibilityElement(children: .ignore)
.accessibilityLabel(ProfileLocalization.settingsVideo)
.accessibilityLabel(ProfileLocalization.datesAndCalendar)
.cardStyle(
bgColor: Theme.Colors.textInputUnfocusedBackground,
strokeColor: .clear
Expand All @@ -155,7 +155,7 @@ public struct SettingsView: View {
.accessibilityIdentifier("video_settings_button")
}
.accessibilityElement(children: .ignore)
.accessibilityLabel(ProfileLocalization.settingsVideo)
.accessibilityLabel(ProfileLocalization.manageAccount)
.cardStyle(
bgColor: Theme.Colors.textInputUnfocusedBackground,
strokeColor: .clear
Expand Down
2 changes: 2 additions & 0 deletions Profile/Profile/SwiftGen/Strings.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ public enum ProfileLocalization {
public static let contact = ProfileLocalization.tr("Localizable", "CONTACT", fallback: "Contact support")
/// Cookie policy
public static let cookiePolicy = ProfileLocalization.tr("Localizable", "COOKIE_POLICY", fallback: "Cookie policy")
/// Dates & Calendar
public static let datesAndCalendar = ProfileLocalization.tr("Localizable", "DATES_AND_CALENDAR", fallback: "Dates & Calendar")
/// Do not sell my personal information
public static let doNotSellInformation = ProfileLocalization.tr("Localizable", "DO_NOT_SELL_INFORMATION", fallback: "Do not sell my personal information")
/// Edit Profile
Expand Down
1 change: 1 addition & 0 deletions Profile/Profile/en.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
"BIO" = "Bio:";
"SETTINGS" = "Settings";
"SETTINGS_VIDEO" = "Video settings";
"DATES_AND_CALENDAR" = "Dates & Calendar";
"SUPPORT_INFO" = "Support info";
"CONTACT" = "Contact support";
"TERMS" = "Terms of use";
Expand Down
1 change: 1 addition & 0 deletions Profile/Profile/uk.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
"BIO" = "Біо:";
"SETTINGS" = "Налаштування";
"SETTINGS_VIDEO" = "Налаштування відео";
"DATES_AND_CALENDAR" = "Dates & Calendar";
"SUPPORT_INFO" = "Інформація про підтримку";
"CONTACT" = "Cлужби підтримки";
"TERMS" = "Умови використання";
Expand Down
Loading