Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add python 3.11 support #320

Merged
merged 30 commits into from
Apr 11, 2024

Conversation

edx-requirements-bot
Copy link
Contributor

For the details, check the issue openedx/public-engineering#233

@mariajgrimaldi mariajgrimaldi force-pushed the jenkins/add-python312-support-6427965 branch from 7fa7661 to 9020825 Compare March 28, 2024 19:33
@mariajgrimaldi mariajgrimaldi changed the title feat: add python 3.12 support feat: add python 3.11 support Mar 28, 2024
@mariajgrimaldi mariajgrimaldi linked an issue Mar 28, 2024 that may be closed by this pull request
6 tasks
@mariajgrimaldi mariajgrimaldi force-pushed the jenkins/add-python312-support-6427965 branch from 4eedc13 to dec9239 Compare April 11, 2024 01:34
@mariajgrimaldi mariajgrimaldi force-pushed the jenkins/add-python312-support-6427965 branch from 2d1e304 to 04dcd8f Compare April 11, 2024 02:22
@mariajgrimaldi mariajgrimaldi marked this pull request as ready for review April 11, 2024 02:47
@mariajgrimaldi mariajgrimaldi requested a review from a team as a code owner April 11, 2024 02:47
Comment on lines +20 to +21
# Temporary to Support the python 3.11 Upgrade
backports.zoneinfo;python_version<"3.9" # Newer versions have zoneinfo available in the standard library
Copy link
Member

@mariajgrimaldi mariajgrimaldi Apr 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariajgrimaldi mariajgrimaldi force-pushed the jenkins/add-python312-support-6427965 branch from 88a8b82 to f953534 Compare April 11, 2024 12:58
Copy link
Member

@felipemontoya felipemontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It mostly looks good. I left some minor comments inline

tox.ini Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
Copy link
Member

@felipemontoya felipemontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more comments. Approving now

@mariajgrimaldi mariajgrimaldi merged commit 9fe0ae9 into main Apr 11, 2024
9 checks passed
@mariajgrimaldi mariajgrimaldi deleted the jenkins/add-python312-support-6427965 branch April 11, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test openedx-events on Python 3.11
4 participants