-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add python 3.11 support #320
Conversation
7fa7661
to
9020825
Compare
4eedc13
to
dec9239
Compare
2d1e304
to
04dcd8f
Compare
# Temporary to Support the python 3.11 Upgrade | ||
backports.zoneinfo;python_version<"3.9" # Newer versions have zoneinfo available in the standard library |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This happened while upgrading, so I added this line to solve it. I first saw it here: https://github.com/openedx/edx-platform/pull/34374/files#diff-5d9561e5b3b3e81ab39e0475363c7efc72c9c2dfe29940be48ceb72f8a10f173R52-R53
88a8b82
to
f953534
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It mostly looks good. I left some minor comments inline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No more comments. Approving now
For the details, check the issue openedx/public-engineering#233