Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: replace codecov with python-coverage-comment-action #323

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

build: replace codecov with python-coverage-comment-action #323

wants to merge 8 commits into from

Conversation

mariajgrimaldi
Copy link
Member

@mariajgrimaldi mariajgrimaldi commented Feb 27, 2024 •
edited
Loading

Description:
This PR replaces the codecov action for python-coverage-comment-action, continuing with the codecov deprecation efforts and avoiding the coverage upload issues altogether.

These changes were 1stly presented in this PR: #300

ISSUE:
edx/edx-arch-experiments#528

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPI after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 27, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Feb 27, 2024 •
edited
Loading

Thanks for the pull request, @mariajgrimaldi!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/hooks-extension-framework. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 27, 2024 •
edited
Loading

Coverage report

This PR does not seem to contain any modification to coverable code.

@mariajgrimaldi mariajgrimaldi force-pushed the MJG/codecov-depr branch 2 times, most recently from d717cbc to 36e9b4c Compare February 27, 2024 13:47
@mariajgrimaldi mariajgrimaldi changed the title Mjg/codecov depr build: replace codecov with python-coverage-comment-action Feb 27, 2024
@mariajgrimaldi mariajgrimaldi marked this pull request as ready for review February 27, 2024 13:54
@mariajgrimaldi mariajgrimaldi requested a review from a team as a code owner February 27, 2024 13:54
@robrap
Copy link
Contributor

robrap commented Feb 27, 2024

Hello @mariajgrimaldi. I'm not seeing how this addresses Ned's concern detailed here: edx/edx-arch-experiments#528 (comment). I never went very deep with this, so I'm not sure if this just requires testing from a personal fork, or other?

@mariajgrimaldi
Copy link
Member Author

@robrap: Sorry, I totally forgot. I'll research further :). Thanks!

@dianakhuang dianakhuang mentioned this pull request Mar 7, 2024
Open
@robrap robrap added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Mar 21, 2024
@robrap
Copy link
Contributor

robrap commented Mar 21, 2024

@feanil: This PR should have had a waiting-on-author label, which I’ve added. I’m guessing you may have gone through and approved blocked PRs? I wonder if we should double check which of those were actually blocked on the author?

@feanil
Copy link

feanil commented Mar 22, 2024

Ah, thanks for the heads up, yea I missed the details of the comment about external PR coverage checks. I think it's accurate that this needs more work to be able to handle external contributions though it may not be possible. I wonder if we need to just run coverage as a check and fail on violations rather than attempt to post a comment.

@robrap
Copy link
Contributor

robrap commented Mar 22, 2024

@feanil: I didn't look very deeply, but I thought Ned had a plan, and simply didn't get to the work to try to execute it. I could be wrong though.

@mariajgrimaldi
Copy link
Member Author

mariajgrimaldi commented Mar 28, 2024 •
edited
Loading

Hi folks. I'm working on this here: mariajgrimaldi#1, these are the commits I'm currently using. I'll be testing it further and let you know. Thanks for the patience.

@mariajgrimaldi
Copy link
Member Author

mariajgrimaldi commented Mar 28, 2024 •
edited
Loading

It seems to be working: mariajgrimaldi#2. I already added those commits to this PR for you to review. By the way, the comment won't appear in this PR because we need the coverage.yml file in the main branch for it to work.

mariajgrimaldi
mariajgrimaldi commented Mar 28, 2024
View reviewed changes
openedx_events/tests/test_tooling.py Outdated
Comment on lines 382 to 386


class SirNotAppearingInThisFilm(TestCase):
def never_run(self):
print("Hello")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only for testing.

@brian-smith-tcril brian-smith-tcril mentioned this pull request Apr 2, 2024
Open
@mariajgrimaldi mariajgrimaldi mentioned this pull request Apr 11, 2024
Closed
@mphilbrick211
Copy link

Hi @mariajgrimaldi! Just checking in on this to see if it's still in progress?

@mariajgrimaldi
Copy link
Member Author

@mphilbrick211: thanks for the ping! I don't know the current status of this, so I'll convert it to draft for now.

@mariajgrimaldi mariajgrimaldi marked this pull request as draft August 6, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ian2012 Ian2012 Ian2012 approved these changes

@robrap robrap Awaiting requested review from robrap

@timmc-edx timmc-edx Awaiting requested review from timmc-edx

@feanil feanil Awaiting requested review from feanil

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc.
Projects
Contributions
Status: Ready for Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mariajgrimaldi @openedx-webhooks @robrap @feanil @mphilbrick211 @Ian2012 @nedbat