From 8636d58bdd635a70f2b6231336c4dced2e1ac245 Mon Sep 17 00:00:00 2001
From: Alison Langston <46360176+alangsto@users.noreply.github.com>
Date: Fri, 7 Jun 2024 09:17:14 -0400
Subject: [PATCH] fix: remove utf-8 encoding for full name (#481)

---
 CHANGELOG.rst                              | 4 ++++
 lti_consumer/__init__.py                   | 2 +-
 lti_consumer/lti_xblock.py                 | 2 +-
 lti_consumer/tests/unit/test_lti_xblock.py | 4 ++--
 4 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 3a3b8dfc..77512030 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -16,6 +16,10 @@ Please See the `releases tab <https://github.com/openedx/xblock-lti-consumer/rel
 Unreleased
 ~~~~~~~~~~
 
+9.11.3 - 2024-05-30
+-------------------
+* Remove utf-8 encoding for user full name
+
 9.11.2 - 2024-05-30
 -------------------
 * Update python version for pypi publish workflow
diff --git a/lti_consumer/__init__.py b/lti_consumer/__init__.py
index c30d3b3a..e85c6da7 100644
--- a/lti_consumer/__init__.py
+++ b/lti_consumer/__init__.py
@@ -4,4 +4,4 @@
 from .apps import LTIConsumerApp
 from .lti_xblock import LtiConsumerXBlock
 
-__version__ = '9.11.2'
+__version__ = '9.11.3'
diff --git a/lti_consumer/lti_xblock.py b/lti_consumer/lti_xblock.py
index 51021775..08789041 100644
--- a/lti_consumer/lti_xblock.py
+++ b/lti_consumer/lti_xblock.py
@@ -1130,7 +1130,7 @@ def extract_real_user_data(self):
         user_data = {
             'user_email': None,
             'user_username': None,
-            'user_full_name': user.full_name.encode(),
+            'user_full_name': user.full_name,
             'user_language': None,
         }
 
diff --git a/lti_consumer/tests/unit/test_lti_xblock.py b/lti_consumer/tests/unit/test_lti_xblock.py
index 2e812505..153ca812 100644
--- a/lti_consumer/tests/unit/test_lti_xblock.py
+++ b/lti_consumer/tests/unit/test_lti_xblock.py
@@ -1078,7 +1078,7 @@ def test_lti_launch_pii_sharing(
 
         set_user_data_kwargs['person_sourcedid'] = 'fake' if pii_sharing_enabled and ask_to_send_username else None
         set_user_data_kwargs['person_name_full'] = (
-            'fáke fǔll ñamë'.encode() if pii_sharing_enabled and ask_to_send_full_name else None
+            'fáke fǔll ñamë' if pii_sharing_enabled and ask_to_send_full_name else None
         )
         set_user_data_kwargs['person_contact_email_primary'] = (
             'abc@example.com' if pii_sharing_enabled and ask_to_send_email else None
@@ -1867,7 +1867,7 @@ def test_get_lti_1p3_launch_data(
                 expected_launch_data_kwargs["preferred_username"] = fake_username
 
             if ask_to_send_full_name:
-                expected_launch_data_kwargs["name"] = fake_name.encode()
+                expected_launch_data_kwargs["name"] = fake_name
 
             if ask_to_send_email:
                 expected_launch_data_kwargs["email"] = fake_user_email