Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace deprecated import #137

Merged
merged 1 commit into from
Apr 11, 2024
Merged

fix: replace deprecated import #137

merged 1 commit into from
Apr 11, 2024

Conversation

KristinAoki
Copy link
Member

Overview

This replace xblock.fragment with web_fragments.fragment. xblock.fragment was removed as of 2024-02-26. If this xblock is used in a course, the entire course will fail to load.

Test Instructions

  • Checkout the branch
  • Update settings?
  • Anything else?

TODO

  • Compile static assets
  • Lint all files
  • Pass all tests
  • Bump the version number in setup.py
  • Attach screenshots?
  • Code Reviewer 1:
  • Code Reviewer 2:
  • Submit PR against edx-platform to bump the version
  • Upload to PyPi

@KristinAoki KristinAoki merged commit 1c8b0c8 into master Apr 11, 2024
7 checks passed
@KristinAoki KristinAoki deleted the KristinAoki/fix-deprecated-import branch April 11, 2024 20:57
@KristinAoki KristinAoki mentioned this pull request Apr 11, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jristau1984 jristau1984 jristau1984 approved these changes

@bszabo bszabo Awaiting requested review from bszabo

@jesperhodge jesperhodge Awaiting requested review from jesperhodge

@connorhaugh connorhaugh Awaiting requested review from connorhaugh

@rayzhou-bit rayzhou-bit Awaiting requested review from rayzhou-bit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KristinAoki @jristau1984