Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oedb connection issue disable test #404

Merged
merged 8 commits into from
Jul 10, 2024
Merged

Conversation

joda9
Copy link
Collaborator

@joda9 joda9 commented Jul 9, 2024

Description

This pull request addresses current issues with the oedb database by adding pytest.mark.oedbtest to comment out tests that fail. These tests can be run specifically by using the argument --runoedbtest. Additionally, the demandlib version has been restricted to < 0.2.0 because version 0.2.0 keeps failing one test.
Both changes should be reverted, as soon as the issues with the oedialect and demandlib are fixed (see issues #405 and #406).

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • New and adjusted code is formatted using the pre-commit hooks
  • New and adjusted code includes type hinting now
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The Read the Docs documentation is compiling correctly
  • If new packages are needed, I added them to the setup.py, and if needed the rtd_requirements.txt, the eDisGo_env.yml and the eDisGo_env_dev.yml.
  • I have added new features to the corresponding whatsnew file

tests/conftest.py Outdated Show resolved Hide resolved
This was referenced Jul 10, 2024
@birgits birgits self-requested a review July 10, 2024 12:56
@birgits birgits merged commit 0a6bf5b into dev Jul 10, 2024
4 of 7 checks passed
@joda9 joda9 deleted the oedb-connection-issue-disable-test branch July 10, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants