feat: added flag migrations as yaml #583
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixeldrew
force-pushed
the
feature-migrations
branch
7 times, most recently
from
21ae5e9
to
9176179
Compare
|
@nothing0012 can you review this please? |
nothing0012
reviewed
Aug 22, 2024
| get: | ||
| tags: | ||
| - migration | ||
| operationId: runMigrations |
There was a problem hiding this comment.
nit, if it's GET, should this be something like getMigrations?
There was a problem hiding this comment.
yeah, I was a little unsure on this, i'm using this as endpoint to run the migration process. It will only run the migrations if finds new files in the directory
nothing0012
reviewed
Aug 22, 2024
flag migrations as yaml
pixeldrew
force-pushed
the
feature-migrations
branch
from
9176179
to
44f1048
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add service end point to load flag, variants and segments from yaml files
Motivation and Context
I needed the ability to deploy flags as code, I paired these changes with a CI task that will upload a repository of yaml migration files that are written by developers. This allows us to migrate flags through environments with stable keys and to have the flags/changes peer reviewed.
How Has This Been Tested?
Tested using sqlite and mysql, on a osx environment.
Types of changes
Checklist: