Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve Slack & nutripatrol notifiers #1450

Merged
merged 1 commit into from
Oct 28, 2024
Merged

feat: improve Slack & nutripatrol notifiers #1450

merged 1 commit into from
Oct 28, 2024

Conversation

raphael0202
Copy link
Collaborator

  • don't send beauty events to nutripatrol
  • send real text comment to Nutripatrol
  • stop sending moderation notifications to Slack

@raphael0202
feat: improve Slack & nutripatrol notifiers
016d8d8 
- don't send beauty events to nutripatrol
- send real text comment to Nutripatrol
- stop sending moderation notifications to Slack
@raphael0202 raphael0202 requested a review from a team as a code owner October 28, 2024 14:11
@codecov Codecov
Copy link

codecov bot commented Oct 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 54.62%. Comparing base (96401ef) to head (016d8d8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
robotoff/notifier.py 66.66% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1450      +/-   ##
==========================================
- Coverage   54.72%   54.62%   -0.11%     
==========================================
  Files          85       85              
  Lines        8637     8620      -17     
==========================================
- Hits         4727     4709      -18     
- Misses       3910     3911       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raphael0202 raphael0202 merged commit ef0f861 into main Oct 28, 2024
10 of 11 checks passed
@raphael0202 raphael0202 deleted the improve-notifiers branch October 28, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teolemon teolemon teolemon approved these changes

Assignees

@raphael0202 raphael0202

Labels
👮 Moderation notifications 🧪 tests 🧪 unit tests
Projects
🤖 Artificial Intelligence @ Open Food Facts
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphael0202 @teolemon