-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add India configuration #907
Add India configuration #907
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, it looks like we are nearly ready to support deployments to the server!
I noticed a couple of things, can you please take a look and update accordingly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have force pushed the updates to my branch.
7d8f208
to
bbcc907
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there, but I have one change to request as commented.
bbcc907
to
f6ac01b
Compare
7f03d48
to
f6ac01b
Compare
f6ac01b
to
2cb3341
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! This passes CI and looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looking good now. Thank you!
Adding configuration for India.
Please let me know if we should split the changes in different PR (one for key, one for templates/env.j2 ...)