Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add India configuration #907

Merged

Conversation

duleorlovic
Copy link
Contributor

Adding configuration for India.
Please let me know if we should split the changes in different PR (one for key, one for templates/env.j2 ...)

Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, it looks like we are nearly ready to support deployments to the server!

I noticed a couple of things, can you please take a look and update accordingly?

inventory/group_vars/in.yml Outdated Show resolved Hide resolved
roles/app/templates/env.j2 Show resolved Hide resolved
inventory/hosts Outdated Show resolved Hide resolved
roles/app/templates/env.j2 Show resolved Hide resolved
Copy link
Contributor Author

@duleorlovic duleorlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have force pushed the updates to my branch.

inventory/group_vars/in.yml Outdated Show resolved Hide resolved
inventory/hosts Outdated Show resolved Hide resolved
roles/app/templates/env.j2 Show resolved Hide resolved
Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, but I have one change to request as commented.

Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! This passes CI and looks good to me.

Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looking good now. Thank you!

@mkllnk mkllnk merged commit f9d01d1 into openfoodfoundation:master Nov 9, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants