Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catch_error and loading_button error management have diverged #855

Closed
12rambau opened this issue Aug 3, 2023 · 0 comments · Fixed by #879
Closed

catch_error and loading_button error management have diverged #855

12rambau opened this issue Aug 3, 2023 · 0 comments · Fixed by #879
Labels
bug Something isn't working quality generated by code climate refactoring code enhancement

Comments

@12rambau
Copy link
Member

12rambau commented Aug 3, 2023

loading_button has a richer management of error types, I don't know if possible but loading_button should be a decorator on top of the catch_error decorator so that the error management is only coded once.
@12rambau 12rambau added bug Something isn't working quality generated by code climate refactoring code enhancement labels Aug 3, 2023
@12rambau 12rambau mentioned this issue Sep 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working quality generated by code climate refactoring code enhancement
Projects
kaban 2023
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use catch_error in loading_button openforis/sepal_ui
1 participant
@12rambau