fix: display meaningfull message if the folder list is empty #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #867 +/- ##
==========================================
- Coverage 96.58% 96.55% -0.03%
==========================================
Files 39 39
Lines 3802 3804 +2
==========================================
+ Hits 3672 3673 +1
- Misses 130 131 +1
|
dfguerrerom
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #826
Normally all the conection to GEE should be done using either the need_ee method or the need_ee decorator. So in both cases I decided to simply assert if at least one root exist. If not I raise an error. As this will be triggered before the widgets are displayed, it will be visible on the screen.