Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use the pytest fixture for tmp directory #890

Merged
merged 5 commits into from
Nov 20, 2023
Merged

Conversation

12rambau
Copy link
Member

@12rambau 12rambau commented Oct 4, 2023

Fix #873

@dfguerrerom dfguerrerom mentioned this pull request Oct 5, 2023
Copy link

codecov bot commented Nov 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6611e93) 96.54% compared to head (6f1d0cf) 96.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #890   +/-   ##
=======================================
  Coverage   96.54%   96.54%           
=======================================
  Files          39       39           
  Lines        3794     3794           
=======================================
  Hits         3663     3663           
  Misses        131      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dfguerrerom dfguerrerom marked this pull request as ready for review November 19, 2023 15:14
@dfguerrerom
Copy link
Collaborator

@12rambau, I've finished your WIP on this branch.

@12rambau
Copy link
Member Author

Perfect, thanks !
Could you approve the branch so I can make the merge ?

@12rambau 12rambau merged commit a14208d into main Nov 20, 2023
11 checks passed
@12rambau 12rambau deleted the tmp_factory branch November 20, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

use tmp dir factories from pytest in our tests
2 participants