Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove changelog #935

Merged
merged 6 commits into from
Sep 11, 2024
Merged

refactor: remove changelog #935

merged 6 commits into from
Sep 11, 2024

Conversation

dfguerrerom
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.50%. Comparing base (4916eee) to head (c8f36b4).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #935   +/-   ##
=======================================
  Coverage   96.50%   96.50%           
=======================================
  Files          39       39           
  Lines        4003     4003           
=======================================
  Hits         3863     3863           
  Misses        140      140           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dfguerrerom
Copy link
Collaborator Author

@12rambau you installed the sphinx repo as dependency in .readthedocs.yaml file, which uses an unreleased version... I also used that one as the requirements in in the pyproject.toml, do you think it is fine if we just unpin those?

The problem with the build in readthedocs was because we were using the mdinclude directive to include the CHANGELOG.md, but if we are not updating it, I think we can just remove it, but, is there a reason for not update_changelog_on_bump ?

@dfguerrerom dfguerrerom marked this pull request as ready for review August 26, 2024 19:56
@dfguerrerom dfguerrerom merged commit 342f002 into main Sep 11, 2024
9 checks passed
@dfguerrerom dfguerrerom deleted the fix_docs_m2r2 branch September 11, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants