Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear ilicache button #811

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Clear ilicache button #811

merged 2 commits into from
Jul 19, 2023

Conversation

domi4484
Copy link
Member

@domi4484 domi4484 commented Jul 11, 2023 •
edited
Loading

@domi4484 domi4484 marked this pull request as draft July 11, 2023 15:40
@domi4484 domi4484 marked this pull request as ready for review July 12, 2023 12:04
@domi4484 domi4484 requested a review from signedav July 12, 2023 12:04
@domi4484 domi4484 requested a review from signedav July 19, 2023 08:58
signedav
signedav approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@signedav signedav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. Have you tested it out with the whole workflow?

@domi4484
Copy link
Member Author

The code looks good. Have you tested it out with the whole workflow?

I have checked that the cache directories get deleted and then created again when running some ili operations again.

Is there something else I should pay attention?

@signedav
Copy link
Member

No I think it's fine. Thanks.

@domi4484 domi4484 merged commit d96785f into master Jul 19, 2023
6 checks passed
@domi4484 domi4484 deleted the clearIlicache branch July 19, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@signedav signedav signedav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Button to clear ilicache
2 participants
@domi4484 @signedav