store validator config file in project variable #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
signedav
force-pushed
the
configfile
branch
from
efcd9ed
to
ec25d23
Compare
domi4484
approved these changes
Oct 4, 2023
QgisModelBaker/gui/validate.py
Outdated
| self.validator_config_file_line_edit.setText(filename) | ||
| self.config_file_line_edit.setText(self._relative_path(filename)) | ||
|
|
||
| def _save_config_file(self): |
There was a problem hiding this comment.
I would name it _save_config_file_path to make it clear that the path to the file is stored, and not the entire file itself.
Maybe in the gui as well.
Yes, that was my thought. Otherwise you would need to go to the Project Variables and copy it around. |
signedav
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to make the button:
Because a remember checkbox appeared too complicated in the UX and writing automatically seems wrong as well (since it's confusing that it's stored when I use the config file and later i saved the project (maybe because another reason).
The path are stored relative (except when the current project is not yet saved) and passed to ili2db absolute.
When instead of a path a
ilidata:keyis entered, then it works as well. It just saves theilidata:key...Btw. When changing the selected layer, the settings are taken over even if it's the same schema. The config file is not saved per schema but per project instead. This because project settings should not be schema dependent. UsabILIty Hub integration would become impossible otherwise. But when I change the config file value and don't save it on layer change to another schema it resets it to the value from the project config.
Possibilities for UsabILIty Hub Integration
See #829
Resolves #820