Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exceptions on no service file found #943

Merged
merged 7 commits into from
Jul 12, 2024
Merged

Fix exceptions on no service file found #943

merged 7 commits into from
Jul 12, 2024

Conversation

signedav
Copy link
Member

Catch the Exceptions from pgserviceparser when no service file availble or service not found.

@gacarrillor
Copy link
Collaborator

@signedav, is there any related issue?
Yesterday I got one (I'll create the issue right now), and I wonder if this PR would solve it.

@signedav
Copy link
Member Author

Reported by mail

@gacarrillor
Copy link
Collaborator

Reported by mail

Perhaps it's the same issue? #944

Copy link
Collaborator

@gacarrillor gacarrillor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

QgisModelBaker/gui/panel/pg_config_panel.py Outdated Show resolved Hide resolved
@signedav
Copy link
Member Author

Reported by mail

Perhaps it's the same issue? #944

Same issue, yes, but not solved here. I need to make another one in the library. Will trigger you.

@signedav
Copy link
Member Author

signedav commented Jul 11, 2024

@gacarrillor see opengisch/QgisModelBakerLibrary#104 I moved the handling to the library

Copy link
Collaborator

@gacarrillor gacarrillor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just double checked after moving the logic to the lib.

@signedav signedav merged commit 452be33 into master Jul 12, 2024
@signedav signedav deleted the fix_service_file branch July 12, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants