Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modification of baskets and datasets #955

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

gacarrillor
Copy link
Collaborator

@gacarrillor gacarrillor commented Aug 26, 2024

  • Adapt Basket Manager and Create Basket dialogs, as well as their underlying models.
  • Edit basket attributes.
  • Change dataset of a basket.
  • Delete basket.
  • Delete dataset.

Screenshots

Edit basket:
image


Depends on opengisch/QgisModelBakerLibrary#107

…and add tooltips for them; homogenize subdialog names (create/edit dataset)
…corresponding models. The former will list only existing baskets, whereas the latter will show only non-existing ones.
…in BasketManager; for changing the selected basket's dataset, disable datasets that already have a basket for the selected basket's topic (since we shouldn't have 2 baskets for the same topic in the same dataset)
…cute common ili2db operations via Model Baker Library
@gacarrillor gacarrillor marked this pull request as ready for review September 29, 2024 03:00
@signedav
Copy link
Member

signedav commented Oct 1, 2024

Tested it on PG and it runs pretty smooth. Two minor GUI inputs:

  • Maybe "edit" and "remove" icon can be depending on selection.
  • The BID (OID Type) looks like expecting something. Can't we grey it out?
    image

Code review will follow...

QgisModelBaker/utils/ili2db_utils.py Outdated Show resolved Hide resolved
from QgisModelBaker.libs.modelbaker.utils.qt_utils import OverrideCursor


class Ili2DbUtils(QObject):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why's that not in the Library?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll move it :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QgisModelBaker/gui/basket_manager.py Show resolved Hide resolved
@gacarrillor
Copy link
Collaborator Author

Tested it on PG and it runs pretty smooth. Two minor GUI inputs:

* Maybe "edit" and "remove" icon can be depending on selection.
* The BID (OID Type) looks like expecting something. Can't we grey it out?

Addressed in the latest commits.

(After a while playing with colors...) Let's disable those read-only fields :)
It's better for you as well?

image

@signedav
Copy link
Member

signedav commented Oct 7, 2024

Good to merge after a new library release...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants