chore(approvals-ga): remove beta flag for MRF email notifications and approvals

[kevin9foong]

Problem

Need to release mrf email notifications and approvals from beta to General Availability.

Solution

Remove the beta flags for mrf email notifications and approvals.

Note that the mrfEmailNotification beta flag has been retained to prevent accidental reuse of prior flags. I.e., we might have another feature that uses the same flag name of mrfEmailNotification which is not known to the developer cause it no longer exist in the records, but exist in User collection.

Breaking Changes

• No - this PR is backwards compatible

Tests

Test set up:

• Create an MRF form called 'finance claims approval'
• Add 2 approval yes/no fields named 'RO approve', 'Finance dept approve'. Assert that Use for approvals badge appears beside yes/no fields in drawer.
• Add 2 email fields
• Assign 1 email field to step 1 to edit, Assign approval field to step 2 to edit and Assign approval field to step 3 to edit. (do not assign approval field or step 1 email notification field yet)
• Let step 2 be static email, let step 3 be dynamic email field

TC1: Regression test - MRF still works

• Open the form to public
• Respond to form, ensure that all steps of mrf can be completed and result is in admin responses tab.
• Assert no email outcomes are sent, since not yet configured in email notification settings.

TC2: Regression test - email notif works:

• From TC1, config email notif setting to step 2 and static email of choice.
• Complete submission, assert that workflow completed (note that it is not an outcome status email) is sent to expected emails.
• Remove the email notifs to prepare for TC3.

TC3: Approve without email notif. Expect no email sent

• Assign approval field to step 2 only.
• Complete all 3 steps of mrf workflow and approve at step 2.
• No email is sent.

TC4: Reject without email notif. Expect no email sent

• Use same form from TC3
• Reject at step 2 of mrf workflow.
• No email is sent to step 3 respondent since workflow ends, no outcome email is sent.

TC5: Approve and reject with email notification works:

• Add step 1 and step 3 to email notification and a static email to email notification.
• Repeat TC3. Assert that only email from step 3 and static email receives approve email, since step 1 does not have email field setup.
• Add email field to step 1 in workflow.
• Repeat TC4. Assert step 1 and step 3 and static email receive not approved email.

TC6: Multiple approval steps - approve all

• From TC5, add approval step for step 3 of workflow.
• Approve all approval steps, approve email should be received.

TC7: Multiple approval steps - Reject at step 2 (middle step)

• From TC6, make submission
• Reject at step 2, assert R3 does not receive email and not approved email is sent to expected emails.

TC8: Multiple approval steps - Reject at last step

• From TC7, make submission
• Approve at step 2 but Reject at step 3, assert not approved email is sent to all expected emails.

Edge cases:
TC10: approval field set to optional, respondent did not fill

• From TC9, set the approval field used for step 2 as optional.
• Try and submit the steps of form, but at step 2, do not fill in the optional approval field.
• assert that R3 no longer gets the next step email, no completion/approval outcome emails are sent.
• Visit the responses page, the R2 submission is recorded.
• Share the next step response link, it goes to R3 and can be resumed.
• Try and submit R3 and approve/reject, it should send out approved/reject email to expected emails.

TC10: approval field deleted, admin did not reassign

• From TC9, delete the approval field used for step 2.
• Try and submit the steps of the form.
• assert that R3 no longer gets the next step email, no completion/approval outcome emails are sent.
• Visit the responses page, the R2 submission is recorded.
• Share the next step response link, it goes to R3 and can be resumed.
• Try and submit R3 and approve/reject, it should send out approved/reject email to expected emails.

[kevin9foong]

Tested on local

[datadog-opengovsg]

Datadog Report

Branch report: chore/remmove-approvals-beta
Commit report: d3a5fa7
Test service: formsg

✅ 0 Failed, 2300 Passed, 1 Skipped, 5m 21.2s Total duration (1m 41.89s time saved)

[KenLSM]

LGTM! Yay for deletions.