fix: validate fallbackUrl as well

opengovsg · Nov 19, 2024 · 9a59ec6 · 9a59ec6
1 parent fb00ae5
commit 9a59ec6
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/packages/validators/src/url/index.ts b/packages/validators/src/url/index.ts
@@ -1,4 +1,4 @@
-import { ZodError, ZodSchema, ZodTypeDef } from 'zod'
+import { string, ZodError, ZodSchema, ZodTypeDef } from 'zod'
 import { fromError } from 'zod-validation-error'
 
 import { OptionsError } from '@/common/errors'
@@ -79,7 +79,7 @@ export class UrlValidator {
       if (error instanceof UrlValidationError && fallbackUrl !== undefined) {
         // URL validation failed, return the fallback URL
         // This is NOT validated.
-        return fallbackUrl
+        return this.#parse(fallbackUrl instanceof URL ? fallbackUrl.href : fallbackUrl)
       }
       // otherwise rethrow
       throw error