Build fails on Xcode 15

[timbms]

New bug checklist

• [ x] I updated the iOS openHAB app to the latest TestFlight version.
• [ x] I read the Contribution Guidelines
• [ x] I searched for existing GitHub issues

Describe the bug
Build fails on Xcode 15

• ImageResource conflicts definition in GeneratedAssetSymbols.swift. Needs to be changed to KF.ImageResource
• Could not get GOOGLE_APP_ID in Google Services file from build environment

Expected behavior
Build on latest platform

[digitaldan]

So I'm struggling right now on 15 with a number of build errors, SwiftFormatPlugin is producing errors about not being able to write caches, i'm getting errors from "Argument type 'ImageResource' does not conform to expected type 'Resource'" in IconView.swift, and a few others. Trying at least to get fastlane working locally so i can grab some screenshots for our next app release.

[digitaldan]

Well here's the Kingfisher image issue, i'll post a PR shortly

onevcat/Kingfisher#2090

[weakfl]

SwiftFormatPlugin is producing errors about not being able to write caches

@digitaldan Apple has fixed the plugin sandbox, only command plugins are allowed to write now. Lmk when you have a PR for Kingfisher ready and I can fix the plugins on top of it.

[digitaldan]

#731

thanks!

[digitaldan]

So FYI, fastlane runs for me, launches simulators and runs through the automated UI tests, but can not take screenshots, not sure if this is the sandboxing issue affecting the swiftformat plugin ? also that reminds me i have a fix for the UI tests not working with the main UI (not sure if there was a main UI dom change or what). I'll submit that soon too.

[digitaldan]

Anyone have any luck getting fastlane to create UI snapshots? Its failing on my machine, but without any error which is strange. I can confirm the UI Tests run ok with my other PR, just no snapshot and no errors, but fastlane does show it as failed. This is probably a config issue on my machine (M1 pro mac using fastlane 2.216.0).

[weakfl]

@digitaldan looks like the UITests are failing because some element can't be found. Just try running without fastlane and you should see where it's failing:

Failed to tap Image (Children matching type Image): No matches found for Children matching type Link from input {(
    Other
)}
Possibly caused by runtime issues:
Automation type mismatch: computed Other from legacy attributes vs WebView from modern attribute. Input attributes and values: {
    "XC_kAXXCAttributeAutomationType" = 58;
    "XC_kAXXCAttributeElementBaseType" = UIView;
    "XC_kAXXCAttributeElementType" = WKWebView;
    "XC_kAXXCAttributeTraits" = 146028888064;
}
Automation type mismatch: computed Other from legacy attributes vs WebView from modern attribute. Input attributes and values: {
    "XC_kAXXCAttributeAutomationType" = 58;
    "XC_kAXXCAttributeElementBaseType" = UIView;
    "XC_kAXXCAttributeElementType" = WKContentView;
    "XC_kAXXCAttributeTraits" = 146028888064;
}
See test report attachments for more detail.

[digitaldan]

So with my PR #733 , i'm not seeing those errors, at least not in the xcode console log (maybe somewhere else). Its strange b/c at the begining of the log it shows this:

est Suite 'All tests' started at 2023-10-17 11:40:15.954.
Test Suite 'openHABUITests.xctest' started at 2023-10-17 11:40:15.954.
Test Suite 'OpenHABUITests' started at 2023-10-17 11:40:15.954.
Test Case '-[openHABUITests.OpenHABUITests testShots]' started.
    t =     0.00s Start Test at 2023-10-17 11:40:15.955
    t =     0.05s Set Up
2023-10-17 11:40:16.014981-0700 openHABUITests-Runner[15143:2017343] The operation couldn’t be completed. (openHABUITests.SnapshotError error 4.)
    t =     0.06s     Open es.spaphone.openhab
    t =     0.06s         Launch es.spaphone.openhab
    t =     1.35s             Setting up automation session
    t =     2.18s             Wait for es.spaphone.openhab to idle

But then at the end it shows everything passed, and there was no other failures listed in between

Test Case '-[openHABUITests.OpenHABUITests testShots]' passed (92.830 seconds).
Test Suite 'OpenHABUITests' passed at 2023-10-17 11:41:48.785.
	 Executed 1 test, with 0 failures (0 unexpected) in 92.830 (92.831) seconds
Test Suite 'openHABUITests.xctest' passed at 2023-10-17 11:41:48.786.
	 Executed 1 test, with 0 failures (0 unexpected) in 92.830 (92.831) seconds
Test Suite 'All tests' passed at 2023-10-17 11:41:48.786.
	 Executed 1 test, with 0 failures (0 unexpected) in 92.830 (92.833) seconds

I'll keep looking at it, not sure what the deal is .