Handle iconcolor in basicui for iconify icons #728
Conversation
|
cc @digitaldan |
|
Hmm, hold off on reviewing this. I need to look through openhab/openhab-webui#1743 and linked issues and PRs. I may change how things implemented to more closely match the web wrt dark mode. |
And for dark mode, if no color is specified, use white Note that for icons that are already colored, they won't change. Iconify only modifies icons with `fill="currentColor"`. Signed-off-by: Cody Cutrer <cody@cutrer.us>
ccutrer
force-pushed
the
basic-ui-iconcolor
branch
from
65ab5ed
to
a34cfc7
Compare
ccutrer
changed the title
|
Okay, this is much better, and simpler, and matches how the web BasicUI works. |
There was a problem hiding this comment.
LGTM. I ran it through some quick tests with the one sitemap i have, i did not get to test the iconify support, but i trust that was tested and is working. I'll push out a test flight build right now, f you can verify this looks good once thats out, i'll plan on an official release end of week.
|
The TestFlight build has been working great for the past two weeks on three different phones at my house, including automatic dark mode transitions, and a huge variety of iconify icons on a very large sitemap. |
And for dark mode, if no color is specified, use white.
Note that for icons that are already colored, they won't change. Iconify only modifies icons with
fill="currentColor".